refactor: [M3-6282] MUI v5 Migration - SRC > Features > StackScripts pt2

[coliu-akamai]

Description 📝

Part 2 of migrating the MUI styling for the StackScripts package. This PR is for the StackScriptsPanel, UserDefinedFieldsPanel, subpackages and the files in the root package.

Once Part 1 gets merged in, will rebase this PR to get rid of merge conflicts

Changes 🔄

• Migrated styling from makeStyles to use Styled components and sx
• Removed React.FC
• updated imports to be named exports instead of default exports (unless lazily exported / the component had higher order functions applied to it)
• removed unnecessary index.tsx files

How to test 🧪

There should be no visual changes.

Prerequisites

(How to setup test environment)

• Set up local host and navigate to the stack scripts section

Verification steps

(How to verify changes)

• Verify that the StackScripts details page is the same
• Verify that rebuilding a linode from a StackScript still looks and functions the same

Additionally re-verify part I's checks:

• Verify that there are no visual changes on the StackScript landing page
• Verify that the StackScript create page still looks and functions the same
• Verify that the StackScript section in the Linode Create flow still looks and functions the same

As an Author I have considered 🤔

Check all that apply

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[coliu-akamai]

Removed this RenderGuard as the StackScriptRow isn't using it (no updateFor props passed in where it's being used)

[coliu-akamai]

(removing Hana since she's OOO!)

[abailly-akamai]

Looks great! thanks for the cleanup

• Found no styling regression ✅
• Found no console errors from new styled components ✅
• Found no functionality regression on either stackscript or marketplace flows

Left a few comments for some cleanup

[mjac0bs]

Overall, this looked good! Tested Stackscripts landing, create, and details page, rebuilding from Stackscript, and create from Stackscript.

I did notice one minor spacing change between the Revision Note field and the action buttons at the bottom of StackScripts Create -- was this intentional?

Prod	This Branch

I also noticed two things unrelated to this PR and present in prod, but, I think, worth follow up ticket(s) to address:

• On the edit form, when a stackscript is submitted without an image, the help icon shifts downward to be off-center once the error appears beneath the text field.

Screen.Recording.2023-10-17.at.9.52.18.AM.mov

• When a user tries to submit a stackscript without a label and image, receives validation errors, and then comes back into that same edit form, the field values don't repopulate with the label and image data, even though they are present in the API request for that stackscript.

No prepopulated label and image fields:

Screen.Recording.2023-10-17.at.9.53.21.AM.mov

The request that was made when the edit form was loaded, which includes the existing label and image data:

[coliu-akamai]

Thanks for catching Mariah! Fixed spacing + created tickets [M3-7280] and [M3-7281] for these bugs!