change: [M3-7266] - Improve Linode Create Error Placement#9788
Conversation
| return ( | ||
| <Paper | ||
| sx={{ | ||
| backgroundColor: theme.color.white, |
There was a problem hiding this comment.
This made the paper the wrong color
| > | ||
| <div className={innerClass}> | ||
| {error && <Notice variant="error">{error}</Notice>} | ||
| <Grid container sx={{ display: 'flex' }}> |
There was a problem hiding this comment.
Great example of why a simple Box with flex is much cleaner than a Grid
| boxShadow: `inset 0 -1px 0 ${theme.borderColors.divider}`, | ||
| marginBottom: theme.spacing(3), | ||
| marginTop: 22, | ||
| marginTop: theme.spacing(1), |
There was a problem hiding this comment.
This tightens up the spacing between the "Linode Plan" heading and the plan tabs
| className | ||
| )} | ||
| > | ||
| {error ? <Notice text={error} variant="error" /> : null} |
There was a problem hiding this comment.
This error is now passed to errorText of the PasswordInput
| sx={{ flexGrow: 1, ...sx }} | ||
| > | ||
| <div className={innerClass}> | ||
| {error && <Notice variant="error">{error}</Notice>} |
There was a problem hiding this comment.
This error is now below the heading
bnussman-akamai
requested review from
cliu-akamai and
dwiley-akamai
and removed request for
a team
|
Should this be a |
bnussman-akamai
changed the title
I'd vote for fix. There was a lot of 🧹 🧼 here! |
There was a problem hiding this comment.
In your screenshot of the marketplace app Minecraft: Java Edition I noticed we're using grid items without a grid container. See https://github.com/linode/manager/blob/develop/packages/manager/src/features/StackScripts/UserDefinedFieldsPanel/UserDefinedFieldsPanel.tsx#L252
We probably want to do something like:
<Grid container key={`${field}-${idx}`} spacing={2}>
{renderField(udf_data, handleChange, field, error)}
</Grid>
| import { Tabs } from 'src/components/ReachTabs'; | ||
| import { Typography } from 'src/components/Typography'; | ||
|
|
||
| import { Box } from '../Box'; |
There was a problem hiding this comment.
Do we want to do src/components/Box?
|
✅ Tested all the screens and errors. Approving since my suggestions were minor |
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Styles of all validation errors ✅
General spacing of the Linode Create page ✅
Linode Rebuild Dialog looks ok ✅
Marketplace App user defined passwords look ok ✅
mjac0bs
added
Approved
5 participants
Description 📝
Changes 🔄
errorTextfor errors that relate to TextFieldsPreview 📷
How to test 🧪
Verification steps
http://localhost:3000/linodes/createCreate Linodeat the bottomAs an Author I have considered 🤔
Check all that apply