fix: [M3-7270] - Edit Linode VLAN config interface#9798
Merged
hana-akamai merged 4 commits intolinode:developfrom Oct 17, 2023
Merged
fix: [M3-7270] - Edit Linode VLAN config interface#9798hana-akamai merged 4 commits intolinode:developfrom
hana-akamai merged 4 commits intolinode:developfrom
Conversation
jdamore-linode
approved these changes
Oct 17, 2023
Contributor
jdamore-linode
left a comment
jdamore-linode
left a comment
There was a problem hiding this comment.
Nice, thanks @hana-linode! Confirmed that the tests are passing and that the config dialog is working as expected
hana-akamai
changed the title
Contributor
Author
|
Since this is a bug from a recent story that hasn't released yet, I don't think this needs a changeset |
hana-akamai
requested review from
carrillo-erik,
cliu-akamai,
coliu-akamai and
cpathipa
and removed request for
a team and
cliu-akamai
coliu-akamai
approved these changes
Oct 17, 2023
Contributor
coliu-akamai
left a comment
coliu-akamai
left a comment
There was a problem hiding this comment.
🎉 awesome thanks Hana!
✅ confirmed that config dialog works as expected with vlans
✅ confirmed that tests pass
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Bug from #9709
On the prod env, we were unable to edit a config due to the config interface being deleted. This was due to the
regionHasVPCsvariable being coupled withregionHasVLANSin the if statement to delete config interfaces. The fix was to handle VPCs and VLANs separately.Note: Linode details have been obfuscated
Preview 📷
before.mov
after.mov
How to test 🧪
Prerequisites
Reproduction steps
ConfigurationstabVerification steps