feat: [M3-7267] - Add AGLB Rule Delete Dialog

[bnussman-akamai]

Description 📝

• Adds the functionality to delete rules from an AGLB route 🗑️🎉

Preview 📷

How to test 🧪

Prerequisites

• Turn on the MSW
• Navigate to http://localhost:3000/loadbalancers/0/routes

Verification steps

• Expand any of the Routes ⬇️
• Attempt to delete a rule on a route 🗑️
• Verify the route gets deleted ☑️

Test:

yarn cy:run -s "cypress/e2e/core/loadBalancers/load-balancer-routes.spec.ts"

As an Author I have considered 🤔

Check all that apply

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[dwiley-akamai]

Functionality per verification steps looks good ✅
load-balancer-routes.spec.ts passed locally ✅
Code review ✅

[mjac0bs]

Rule deletes successfully and load-balancer-routes.spec.ts passed. ✅

The UX of this has probably been discussed, but can you remind me why our action menu uses the language "Remove" and the modal uses the language "Delete"? This mismatch seems a little odd to me, so I wondered what the intent was.

[bnussman-akamai]

I agree @mjac0bs. I took this down as something to address later. Probably was just a UX oversight

[bnussman-akamai]

Actually, I'm just going to make it Delete. Remove doesn't make any sense here. Once the rule is "Removed", it's completely gone and there is no chance of adding it back

[mjac0bs]

Actually, I'm just going to make it Delete. Remove doesn't make any sense here. Once the rule is "Removed", it's completely gone and there is no chance of adding it back

Sounds good to me!