feat: [M3-7028] - Add AGLB Edit Route Drawer#9822
feat: [M3-7028] - Add AGLB Edit Route Drawer#9822bnussman-akamai merged 16 commits intolinode:developfrom
Conversation
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/LoadBalancerRoutes.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/EditRouteDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/RuleDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/EditRouteDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/EditRouteDrawer.tsx
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/EditRouteDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/RuleDrawer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
- Observe drawer opens
- Title containing specific route label
- Input field containing current route label
- Current protocol selected
- Observe when click Edit Route network payload should contain your new options
- Run cypress tests yarn cy:run -s cypress/e2e/core/loadBalancers/load-balancer-routes.spec.ts
Confirming on the above validation tasks and I haven't seen any regression. I agree with @bnussman-akamai feedback.
Questions:
I have noticed that other places of edit scenarios I feel like language for the primary button is inconsistent. "Save Changes" make sense to me.
| Edit Route | Edit Volume |
|---|---|
![]() |
![]() |
I've also noticed inconsistency of whether we include data next to the title or not (ie: |
|
I think we should do what is most common in Cloud Manager. I think that would be |
Looking good now 👍 |
packages/manager/cypress/e2e/core/loadBalancers/load-balancer-routes.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/EditRouteDrawer.tsx
Show resolved
Hide resolved
mjac0bs
left a comment
There was a problem hiding this comment.
Confirmed routes update as expected and editing a route to be labelless is no longer possible. 🚢


Description 📝
Implements the AGLB edit route drawer.
Preview 📷
edit-route.mp4
How to test 🧪
Prerequisites
Reproduction steps
...next to a routeEditbuttonVerification steps
Edit Routenetwork payload should contain your new optionsyarn cy:run -s cypress/e2e/core/loadBalancers/load-balancer-routes.spec.tsAs an Author I have considered 🤔
Check all that apply