fix: [M3-7298] - Improve Footer Styles#9823
Merged
bnussman-akamai merged 4 commits intolinode:developfrom Oct 23, 2023
Merged
Conversation
bnussman-akamai
added
Bug
bnussman-akamai
requested review from
cliu-akamai and
dwiley-akamai
and removed request for
a team
dwiley-akamai
approved these changes
Oct 20, 2023
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Nice improvement 👍
Version link still works ✅
Animation looks good ✅
Mobile view ✅
| desktopMenuIsOpen: boolean; | ||
| } | ||
|
|
||
| const FEEDBACK_LINK = 'https://www.linode.com/feedback/'; |
Contributor
There was a problem hiding this comment.
Maybe we should move this to src/constants? Seems there's precedent there since the link for the Community site is in there too
bnussman-akamai
added
Approved
| const StackScripts = React.lazy(() => import('src/features/StackScripts/StackScripts')); | ||
| const StackScripts = React.lazy( | ||
| () => import('src/features/StackScripts/StackScripts') | ||
| ); |
Contributor
There was a problem hiding this comment.
I've seen this one before 🤣
| desktopMenuIsOpen: boolean; | ||
| } | ||
|
|
||
| const FEEDBACK_LINK = 'https://www.linode.com/feedback/'; |
| xs: 2, | ||
| }, | ||
| paddingY: theme.spacing(2.5), | ||
| transition: 'all .1s linear', // match the sidebar transition speed |
Contributor
There was a problem hiding this comment.
transition: 'all' can be expensive an unnecessary. Just transition the property you're interested in
Member
Author
There was a problem hiding this comment.
Neat. I didn't know this! Thank you!
This was referenced Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Changes 🔄
xsviewportsGridPreview 📷
New Animation ✨
Screen.Recording.2023-10-20.at.12.43.36.PM.mov
How to test 🧪
Reproduction steps
Verification steps
As an Author I have considered 🤔