refactor: [M3-7098] - Create Stack component#9830
refactor: [M3-7098] - Create Stack component#9830bnussman-akamai merged 10 commits intolinode:developfrom
Stack component#9830Conversation
bnussman-akamai
requested review from
carrillo-erik and
dwiley-akamai
and removed request for
a team
| title: 'Components/Spacer', | ||
| }; | ||
|
|
||
| export default meta; |
There was a problem hiding this comment.
Hmm.. This component is opinionated about layout composition. Increasing its usage means adding empty divs everywhere for building very basic layouts, which can be achieved with a simple flexbox space-between container (and occasional grouping of children). Not a fan of adding empty markup everywhere for this purpose. It also could make responsive development less intuitive.
I thought you were already complaining about too many divs 😆 ! What is your reasoning?
There was a problem hiding this comment.
I just appreciate the convenience of it but I can see that side of things too.
My main complaint is Cloud Manager's overuse of MUI Grid.
There was a problem hiding this comment.
My main complaint is Cloud Manager's overuse of MUI Grid.
While I agree, I don't think this solves it. Besides Grid has responsive handling baked in, this component will need some customisation and extra sx with breakpoints to achieve the same. All that being said it would be nice to have a session on layout composition and spend more time discussing when and where to use what.
There was a problem hiding this comment.
I don't think this solves it
Agree with this
bnussman-akamai
changed the title
Stack and Spacer componentsStack component
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
I still need to test it in Storybook some more but I noticed a couple of typos
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
|
I did not observe any visual defects with these changes. Running Storybook locally worked as expected. I think this component is a great addition to our component library. |
abailly-akamai
left a comment
abailly-akamai
left a comment
There was a problem hiding this comment.
Looks great! nice addition.
Put an item to discuss layout composition with the team and will include this one as well
5 participants
Description 📝
Stackto our "component library"Changes 🔄
StackcomponentPreview 📷
How to test 🧪
Storybook
yarn storybookStackstory for styling, functionality, and spellingCloud Manager
As an Author I have considered 🤔