refactor: [M3-6963] - MUI v5 Migration - Src > Component > Breadcrumb#9877
refactor: [M3-6963] - MUI v5 Migration - Src > Component > Breadcrumb#9877tyler-akamai merged 4 commits intolinode:developfrom tyler-akamai:M3-6963-css-migration-finalcrumbprefix
Src > Component > Breadcrumb#9877Conversation
| }, | ||
| className | ||
| )} | ||
| <StyledRootDiv |
There was a problem hiding this comment.
The original code has two makeStyle classes. One had the bulk of the styling, the other just has a single style element that would be added if hasError == true. So instead of making two separate Styled api components, I created one with the basic styling, and the have an sx component that adds margin to the bottom if hasError == true
Src > Component > Breadcrumb
bnussman-akamai
left a comment
There was a problem hiding this comment.
Didn't notice any regressions 🔎
cpathipa
left a comment
There was a problem hiding this comment.
LGTM! Verified Breadcrumbs, no regressions found.
mjac0bs
left a comment
There was a problem hiding this comment.
Thanks @tyler-akamai! One nitpick: there are some linter warnings in the files for imports that would be nice to fix. I also left an optional suggestion about the bottom margin for the error on label.
Confirmed the following:
✅ Verify that the Breadcrumbs match the page for each product (Linode, NodeBalancers, Firewalls, etc.)
✅ Verify that the Breadcrumb matches the instance of the details page (Click on a specific Linode, NodeBalancer, Firewall, etc.)
✅ Verify that you can edit the name of the instance (ex. you can edit the name of the Linode that you selected via the breadcrumb)
✅ Verify that the name is saved and used in the landing page
Description 📝
MUI v5 Migration - Src > Component > Breadcrumb
Changes 🔄
List any change relevant to the reviewer.
Preview 📷
Include a screenshot or screen recording of the change
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply