Skip to content

upcoming: [M3-7365] - New endpoints, query, types and mock data for Sold Out Plans#9878

Merged
coliu-akamai merged 7 commits intolinode:developfrom
coliu-akamai:feat-m3-7365
Nov 7, 2023
Merged

upcoming: [M3-7365] - New endpoints, query, types and mock data for Sold Out Plans#9878
coliu-akamai merged 7 commits intolinode:developfrom
coliu-akamai:feat-m3-7365

Conversation

@coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Nov 6, 2023

Description 📝

  • Adds api-v4 endpoints and types for Sold Out Plans
  • Adds react queries and mock data for Sold Out Plans

How to test 🧪

This should have no impact (yet) on customer facing codebase.

Verification steps

  • Review endpoints, spelling, and types -- cross reference endpoints and types with these two endpoints: one and two
  • If you'd like to test the MSW, you can use the react queries in some file and check the network calls. You can also cross reference the shape of the data returned by the MSW with the data returned from the actual queries
  • Verify /regions/:regionId endpoint still works as expected (changed regionID to regionId for the input name)

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

* Return detailed information about a particular region.
*
* @param regionID { string } The region to be retrieved.
* @param regionId { string } The region to be retrieved.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing this to regionId instead of regionID as per one of the discussions in our FrontendCafe, since I was working in this file anyway

@coliu-akamai coliu-akamai marked this pull request as ready for review November 6, 2023 21:11
@coliu-akamai coliu-akamai requested a review from a team as a code owner November 6, 2023 21:11
@coliu-akamai coliu-akamai requested review from abailly-akamai and bnussman-akamai and removed request for a team November 6, 2023 21:11
@coliu-akamai coliu-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Nov 7, 2023
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, we're getting data!

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 7, 2023
@coliu-akamai coliu-akamai merged commit ab55d6a into linode:develop Nov 7, 2023
@coliu-akamai coliu-akamai deleted the feat-m3-7365 branch December 19, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Sold Out Plans

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants