fix: [M3-7331] - VPC and StackScript details overflow#9887
Merged
coliu-akamai merged 8 commits intolinode:developfrom Nov 15, 2023
Merged
fix: [M3-7331] - VPC and StackScript details overflow#9887coliu-akamai merged 8 commits intolinode:developfrom
coliu-akamai merged 8 commits intolinode:developfrom
Conversation
mjac0bs
approved these changes
Nov 14, 2023
Contributor
mjac0bs
left a comment
There was a problem hiding this comment.
Thanks for fixing both of these! Confirmed that the description field now wraps rather than overflows on StackScript details and VPC details. Search bar placeholder text is no longer cut off.
| StackScripts ✅ | VPC ✅ |
|---|---|
![]() |
![]() |
I think extending the width of the search bar is fine. It seems like there's some default styling for the MUI TextField component that is setting that font size to 1rem at smaller viewports and that would need to get overridden to go that styling route, but I couldn't make it happy either.
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
bnussman-akamai
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description + notes on some changes 📝
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply