Skip to content

fix: [M3-7405] - Take care of 'oh snap' errors from MSW#9910

Merged
coliu-akamai merged 2 commits intolinode:developfrom
coliu-akamai:server-handler-fixes
Nov 16, 2023
Merged

fix: [M3-7405] - Take care of 'oh snap' errors from MSW#9910
coliu-akamai merged 2 commits intolinode:developfrom
coliu-akamai:server-handler-fixes

Conversation

@coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Nov 16, 2023

Description 📝

During release testing, we ran into a bunch of 'oh snap' popups due to the MSW. This PR should hopefully get rid of them all - the issues seem to stem from VPC and Firewall mock requests.

Testing

Prerequisites

(How to setup test environment)

  • Use the MSW

Reproduction steps

(How to reproduce the issue, if applicable)

  • Navigate to VPC Landing, Firewall Landing, Linode pages like the Network tab or Configurations tab -- the error pops up on these pages

Verification steps

  • Perform a general check of CM using the MSW and verify that no 'oh snap' errors appear. Confirm they don't appear on ^ pages

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai self-assigned this Nov 16, 2023
@coliu-akamai coliu-akamai changed the title fix: Handle 'oh snap' errors from MSW fix: Take care of 'oh snap' errors from MSW Nov 16, 2023
@coliu-akamai coliu-akamai marked this pull request as ready for review November 16, 2023 15:48
@coliu-akamai coliu-akamai requested a review from a team as a code owner November 16, 2023 15:48
@coliu-akamai coliu-akamai requested review from dwiley-akamai and tyler-akamai and removed request for a team November 16, 2023 15:48
@coliu-akamai coliu-akamai changed the title fix: Take care of 'oh snap' errors from MSW fix: [M3-7405] - Take care of 'oh snap' errors from MSW Nov 16, 2023
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! confirmed not getting the errors anymore ✅

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. Sorry about this!

@coliu-akamai coliu-akamai merged commit 51eefa0 into linode:develop Nov 16, 2023
@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Nov 16, 2023
@coliu-akamai coliu-akamai deleted the server-handler-fixes branch November 21, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants