fix: [M3-7405] - Take care of 'oh snap' errors from MSW#9910
Merged
coliu-akamai merged 2 commits intolinode:developfrom Nov 16, 2023
Merged
fix: [M3-7405] - Take care of 'oh snap' errors from MSW#9910coliu-akamai merged 2 commits intolinode:developfrom
coliu-akamai merged 2 commits intolinode:developfrom
Conversation
abailly-akamai
approved these changes
Nov 16, 2023
Contributor
abailly-akamai
left a comment
There was a problem hiding this comment.
Thank you! confirmed not getting the errors anymore ✅
bnussman-akamai
approved these changes
Nov 16, 2023
Member
bnussman-akamai
left a comment
There was a problem hiding this comment.
thank you. Sorry about this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
During release testing, we ran into a bunch of 'oh snap' popups due to the MSW. This PR should hopefully get rid of them all - the issues seem to stem from VPC and Firewall mock requests.
Testing
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
As an Author I have considered 🤔
Check all that apply