change: [M3-7396] - Update axios to 1.6.1#9911
Merged
bnussman-akamai merged 7 commits intolinode:developfrom Nov 17, 2023
Merged
change: [M3-7396] - Update axios to 1.6.1#9911bnussman-akamai merged 7 commits intolinode:developfrom
axios to 1.6.1#9911bnussman-akamai merged 7 commits intolinode:developfrom
Conversation
bnussman-akamai
added
the
Dependencies
Member
Author
|
Without even debugging, I have 99% confidence that #9817 will resolve what's happening. Looks like a classic ESM/CJS problem |
bnussman-akamai
requested review from
carrillo-erik and
mjac0bs
and removed request for
a team
bnussman-akamai
changed the title
bnussman-akamai
changed the title
axios to 1.6.1
jdamore-linode
approved these changes
Nov 17, 2023
Contributor
jdamore-linode
left a comment
jdamore-linode
left a comment
There was a problem hiding this comment.
Thanks @bnussman-akamai! Seeing that the tests have passed, and spent some time messing around in Cloud Manager and everything seems to be working. Also checked file upload for OBJ and Images and those both worked like they normally do 👍
mjac0bs
approved these changes
Nov 17, 2023
Contributor
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
This looked good -- did not notice any regressions. 🚀
- Tested Cloud Manager in general - checked a variety of CRUD operations and error handling
- Verified file uploads for Object Storage and Images still work
- Verified all CI and e2e pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
axiosto latest 🎉tsupto latest so that we are on the latest esbuildHow to test 🧪
As an Author I have considered 🤔