fix: [M3-7407]: TableCell with ActionMenu incorrect size and border placement#9915
Conversation
There was a problem hiding this comment.
Thanks for fixing!
✅ Confirmed the table row bug is fixed in the AGLB routes page.
Spot checked a few tables throughout the app, checking at various screen sizes:
✅ Confirmed no regressions in kubernetes tables.
✅ Confirmed no regressions in linodes plan table.
✅ Confirmed no regressions in firewall rules table.
coliu-akamai
left a comment
There was a problem hiding this comment.
✅ confirmed that bug is gone from AGLB routes tab!
-- some other spot checks for table cells with actionCell prop passed in:
✅ confirmed VPC table and VPC subnets table still looks as expected
✅ confirmed volumes table still looks as expected
✅ confirmed domains table still looked as expected
✅ confirmed server transfers table still looked as expected
✅ confirmed NodeBalancers landing table still looked as expected
✅ Stackscripts table still looked as expected
Had a quick question that's not part of this PR, but is there a reason why we style the StackScript table header differently than the other table headers - specifically why it doesn't have the divider lines for each cell?

vs others:


|
I don't have a good answer for you. I think it honestly might just be a regression or legacy thing. I can't think of a reason for it to not match all other tables. |
Description 📝
Something about our TableCell with an Action Menu is not working well in some tables. The ActionMenu is causing the TableCell to be the wrong size and position the border incorrectly.☹️
The Fix 🛠️
heightassigned to aTableCellwith theactionCellpropPreview 📷
How to test 🧪
Prerequisites
Verification steps
http://localhost:3000/loadbalancers/0/routesAs an Author I have considered 🤔