Skip to content

change: [M3-7359] - Move Linode Details Add/Edit Config button alignment to the right#9925

Merged
coliu-akamai merged 5 commits intolinode:developfrom
coliu-akamai:feat-m3-7359
Nov 27, 2023
Merged

change: [M3-7359] - Move Linode Details Add/Edit Config button alignment to the right#9925
coliu-akamai merged 5 commits intolinode:developfrom
coliu-akamai:feat-m3-7359

Conversation

@coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Nov 22, 2023

Description 📝

  • Moves the edit/add config action panel's buttons to the right to be more consistent
  • also moved config's styles to a separate file to be in line with our styling guidelines (since file is >100 lines)

Preview 📷

Before After
image image

How to test 🧪

Prerequisites

  • Navigate to a Linode's detail page, on the Configs tab

Verification steps

  • Verify that the buttons are on the right side of the panel in a) Add Config panel and b) Edit config panel
  • Verify there are no other style regressions

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai added the VPC Relating to VPC project label Nov 22, 2023
@coliu-akamai coliu-akamai self-assigned this Nov 22, 2023
@coliu-akamai coliu-akamai marked this pull request as ready for review November 22, 2023 14:30
@coliu-akamai coliu-akamai requested a review from a team as a code owner November 22, 2023 14:30
@coliu-akamai coliu-akamai requested review from bnussman-akamai and tyler-akamai and removed request for a team November 22, 2023 14:30
@coliu-akamai coliu-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Nov 22, 2023
coliu-akamai and others added 2 commits November 22, 2023 14:30
…igs/LinodeConfigDialog.styles.ts

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
@tyler-akamai
Copy link
Contributor

LGTM!

Screenshot 2023-11-27 at 9 32 09 AM

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 27, 2023
@coliu-akamai coliu-akamai merged commit e8f88ec into linode:develop Nov 27, 2023
@coliu-akamai coliu-akamai deleted the feat-m3-7359 branch December 8, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! VPC Relating to VPC project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants