Skip to content

refactor: [M3-7448] - Migrate ActionMenu story to v7 stories#9927

Merged
coliu-akamai merged 5 commits intolinode:developfrom
coliu-akamai:m3-6522-action-menu
Nov 27, 2023
Merged

refactor: [M3-7448] - Migrate ActionMenu story to v7 stories#9927
coliu-akamai merged 5 commits intolinode:developfrom
coliu-akamai:m3-6522-action-menu

Conversation

@coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Nov 22, 2023 •
edited
Loading

Description 📝

  • MIgrated ActionMenu component story to a V7 (.tsx) story

Changes 🔄

  • migrated story
  • added tests
  • removed index file + updated exports

How to test 🧪

Prerequisites

  • pull code
  • yarn && yarn storybook

Verification steps

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai self-assigned this Nov 22, 2023
@coliu-akamai coliu-akamai marked this pull request as ready for review November 22, 2023 17:06
@coliu-akamai coliu-akamai requested a review from a team as a code owner November 22, 2023 17:06
@coliu-akamai coliu-akamai requested review from hana-akamai and mjac0bs and removed request for a team November 22, 2023 17:06
abailly-akamai
abailly-akamai approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Storybook looks great and component imports behave appropriately ✅

@coliu-akamai coliu-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Nov 27, 2023
@bnussman-akamai bnussman-akamai removed the Add'tl Approval Needed Waiting on another approval! label Nov 27, 2023
@bnussman-akamai bnussman-akamai added the Approved Multiple approvals and ready to merge! label Nov 27, 2023
@coliu-akamai coliu-akamai merged commit 1910e8f into linode:develop Nov 27, 2023
abailly-akamai added a commit to abailly-akamai/manager that referenced this pull request Nov 28, 2023
@abailly-akamai @coliu-akamai
asdlkfhasldkjfh (#15)
deb3d85 
* refactor: [M3-7448] - Migrate ActionMenu story to v7 stories (linode#9927)

* remove index file and update imports

* stories.tsx file and added tests

* Added changeset: ActionMenu V7 story migration

* Update ActionMenu.stories.tsx

* fix typo

* up3

---------

Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
@coliu-akamai coliu-akamai deleted the m3-6522-action-menu branch December 8, 2023 16:05
@mjac0bs mjac0bs mentioned this pull request Dec 11, 2023
Merged
@coliu-akamai coliu-akamai self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@mjac0bs mjac0bs Awaiting requested review from mjac0bs mjac0bs is a code owner automatically assigned from linode/cloud-manager-code-reviewers

@hana-akamai hana-akamai Awaiting requested review from hana-akamai hana-akamai is a code owner automatically assigned from linode/cloud-manager-code-reviewers

Assignees

@coliu-akamai coliu-akamai

Labels

Approved Multiple approvals and ready to merge! Storybook

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coliu-akamai @bnussman-akamai @abailly-akamai