test: [M3-7468] - Add Cypress integration test for API maintenance mode handling#9934
Merged
jdamore-linode merged 4 commits intolinode:developfrom Nov 28, 2023
Conversation
jdamore-linode
requested review from
cliu-akamai and
cpathipa
and removed request for
a team
bnussman-akamai
approved these changes
Nov 27, 2023
| */ | ||
| it('shows maintenance screen when API is in maintenance mode', () => { | ||
| mockApiMaintenanceMode(); | ||
| cy.visitWithLogin('/linodes'); |
Member
There was a problem hiding this comment.
Is /linodes significant? Should we consider / instead? It probably makes no difference at all, but maybe we want things to be less /linodes-centric
Contributor
Author
There was a problem hiding this comment.
Yeah there wasn't a lot of thought put into that, I just figured that since / redirects to /linodes anyway, it was as good a choice as any to use here. But / really would make more sense!
jdamore-linode
added
Add'tl Approval Needed
dwiley-akamai
approved these changes
Nov 28, 2023
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Code review ✅
Test passing ✅
jdamore-linode
added
Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Adds an integration test for Cloud Manager's handling of the API's maintenance mode. It confirms that the maintenance mode message and link to status page are shown.
Changes 🔄
How to test 🧪
We can rely on CI for this, but you can run the new test locally with this command:
yarn && yarn build && yarn start:manager:ci, and then:yarn cy:run -s "cypress/e2e/core/general/maintenance-mode.spec.ts"As an Author I have considered 🤔
Check all that apply