upcoming: [M3-7214 - M3-7216, M3-7219, M3-7221, M3-7222] - Add DC Get Well logic to various user flows pt1#9943
Merged
coliu-akamai merged 10 commits intolinode:developfrom Nov 30, 2023
Conversation
7605b76 to
cd27c42
Compare
abailly-akamai
approved these changes
Nov 30, 2023
Contributor
abailly-akamai
left a comment
There was a problem hiding this comment.
Excellent!
Confirmed:
- New services adopting new region filtering and disabled regions showing as expected from mocks ✅
- No regressions in region filtering based on capabilities ✅
- UI and copy for the tooltip ✅
- e2e failure isn't happening locally ✅
packages/manager/src/components/SelectRegionPanel/SelectRegionPanel.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/RegionSelect/RegionSelect.utils.ts
Outdated
Show resolved
Hide resolved
…required prop comments in pt2
jaalah-akamai
approved these changes
Nov 30, 2023
Contributor
jaalah-akamai
left a comment
There was a problem hiding this comment.
Looks good - I was able to see the tooltip with capabilities
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
There will be a part 2 PR for additional stuff later - definitely Kubernetes, potentially Service Transfers
Changes 🔄
getRegionOptionsinRegionSelectto filter regions based on capability - only show the regions that actually support whichever capability we pass in + added relevant testPreview 📷
How to test 🧪
Verification steps
account/availabilityendpoint inserverHandlers.ts)regions.jsonyarn test components/RegionSelectAs an Author I have considered 🤔
Check all that apply