feat: [M3-7412] - Add new Parent/Child api-v4 endpoints by jaalah-akamai · Pull Request #9944 · linode/manager

jaalah-akamai · 2023-11-29T17:51:53Z

Description 📝

New Parent/Child @linode/api-v4 endpoints:

getChildAccounts
getChildAccount
createChildAccountPersonalAccessToken

Changes 🔄

Fixed our request.tsx to not override headers that are explicitly passed in via setHeaders().
New endpoints use a destructured syntax so we can explicitly state which properties we're interested in, without having to define unused arguments, i.e.: const { data: linodes } = useLinodesQuery({}, {}, shouldCheckLinodeCount);

Preview 📷

How to test 🧪

Test for Request.test.tsx

Checkout branch
Run yarn test src/request.test.tsx
Observe passing tests

As an Author I have considered 🤔

Check all that apply

jaalah-akamai · 2023-11-29T18:01:53Z

Actually I will be added a unit test to Request.test.tsx, but everything else is ready for review - I'll get that done in a bit

packages/manager/src/factories/grants.ts

packages/manager/.changeset/pr-9944-upcoming-features-1701281085057.md

…85057.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

packages/api-v4/src/types.ts

packages/manager/src/queries/account.ts

packages/api-v4/src/account/account.ts

packages/api-v4/.changeset/pr-9944-upcoming-features-1701281121547.md

packages/manager/.changeset/pr-9944-upcoming-features-1701281085057.md

packages/api-v4/src/types.ts

packages/manager/src/queries/account.ts

…1547.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

…85057.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

jaalah-akamai · 2023-11-29T22:03:36Z

Is the goal here to store a child token in the React Query cache for often re-use

Exactly

jaalah-akamai · 2023-11-29T22:25:39Z

@bnussman-akamai We're going to update this to a mutation due to a recent ask of needing to revoke tokens 👍

jaalah-akamai · 2023-11-30T07:14:39Z

packages/manager/src/queries/account.ts

+}: ChildAccountPayload) =>
+  useMutation<Token, APIError[], ChildAccountPayload>(() =>
+    createChildAccountPersonalAccessToken({ euuid, headers })
+  );


The way this will work is from the Parent, we'll create an ephemeral token for the child account in order to log in. While in the Proxy account, we'll be able revoke this the typical way by hitting /profile/tokens/{tokenId}.

packages/api-v4/src/account/account.ts

packages/manager/src/request.tsx

packages/manager/src/queries/account.ts

packages/api-v4/src/types.ts

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

jaalah-akamai · 2023-12-01T02:14:54Z

Unit test added 🚀 This should be good now

mjac0bs

Thanks for the unit test. CI looks good; that one e2e failure on rescue-linode is unrelated.

Let's 🚢 !

packages/api-v4/src/account/account.ts

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>

github-actions · 2023-12-02T13:48:54Z

Coverage Report: ✅
Base Coverage: 85.46%
Current Coverage: 85.46%

jaalah added 6 commits November 28, 2023 14:58

feat: [M3-7412] - Add New Parent/Child Endpoints

e0e8740

feat: [M3-7412] - Add New Parent/Child Endpoints

c322b57

More updates to API

1d4f3de

Update imports

553bd76

Update imports

bca03c0

Adjust comment and types

84c7c1f

jaalah-akamai added the Parent / Child Account label Nov 29, 2023

jaalah-akamai self-assigned this Nov 29, 2023

jaalah-akamai requested a review from a team as a code owner November 29, 2023 17:51

jaalah-akamai requested review from carrillo-erik and coliu-akamai and removed request for a team November 29, 2023 17:51

mjac0bs self-requested a review November 29, 2023 17:59

mjac0bs added the @linode/api-v4 Changes are made to the @linode/api-v4 package label Nov 29, 2023

jaalah-akamai changed the title ~~feat: [M3-7412] - Add new Parent/Child @linode/api-v4 endpoints~~ feat: [M3-7412] - Add new Parent/Child api-v4 endpoints Nov 29, 2023

jaalah added 2 commits November 29, 2023 13:04

Added changeset: Add new queries, grants for Parent/Chid

bb75aeb

Added changeset: Add new endpoints for Parent/Child

f862664

mjac0bs reviewed Nov 29, 2023

View reviewed changes

packages/manager/src/factories/grants.ts Outdated Show resolved Hide resolved

packages/manager/.changeset/pr-9944-upcoming-features-1701281085057.md Outdated Show resolved Hide resolved

Update packages/manager/.changeset/pr-9944-upcoming-features-17012810…

1db9828

…85057.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

bnussman-akamai reviewed Nov 29, 2023

View reviewed changes

packages/api-v4/src/types.ts Outdated Show resolved Hide resolved

jaalah added 3 commits November 29, 2023 15:07

Review updates

052e222

Merge branch 'develop' of github.com:linode/manager into M3-7412

23a2e13

Merge branch 'M3-7412' of github.com:jaalah-akamai/manager into M3-7412

e176cae

jaalah-akamai commented Nov 29, 2023

View reviewed changes

packages/manager/src/queries/account.ts Show resolved Hide resolved

Fix merge conflict

eefa593

mjac0bs reviewed Nov 29, 2023

View reviewed changes

packages/api-v4/src/account/account.ts Show resolved Hide resolved

jaalah added 2 commits November 29, 2023 16:37

Review updates

604123a

Update query name

0532757

dwiley-akamai reviewed Nov 29, 2023

View reviewed changes

packages/api-v4/.changeset/pr-9944-upcoming-features-1701281121547.md Outdated Show resolved Hide resolved

packages/manager/.changeset/pr-9944-upcoming-features-1701281085057.md Outdated Show resolved Hide resolved

bnussman-akamai reviewed Nov 29, 2023

View reviewed changes

packages/api-v4/src/types.ts Outdated Show resolved Hide resolved

packages/manager/src/queries/account.ts Show resolved Hide resolved

jaalah-akamai and others added 2 commits November 29, 2023 17:02

Update packages/api-v4/.changeset/pr-9944-upcoming-features-170128112…

8360bc4

…1547.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

Update packages/manager/.changeset/pr-9944-upcoming-features-17012810…

e1152cf

…85057.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

jaalah added 4 commits November 29, 2023 20:27

Update query to mutation

6049b66

Merge branch 'M3-7412' of github.com:jaalah-akamai/manager into M3-7412

818ed5d

Update RequestHeaders types

489d5f5

Update RequestHeaders types

73337fc

jaalah-akamai commented Nov 30, 2023

View reviewed changes

mjac0bs reviewed Nov 30, 2023

View reviewed changes

jaalah-akamai and others added 7 commits November 30, 2023 14:18

Update packages/api-v4/src/account/account.ts

7eb4a61

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

Update packages/manager/src/request.tsx

50e1551

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

Update packages/manager/src/queries/account.ts

ac14ce5

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

Update packages/manager/src/queries/account.ts

05dbe8f

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

Fix remaining hasExplicitAuthToken instances

95f919c

Update logic

d2ec8fb

Add unit test for explicit auth header

c2ffb4c

mjac0bs approved these changes Dec 1, 2023

View reviewed changes

bnussman-akamai approved these changes Dec 1, 2023

View reviewed changes

packages/api-v4/src/account/account.ts Show resolved Hide resolved

packages/api-v4/src/account/account.ts Outdated Show resolved Hide resolved

mjac0bs added the Approved Multiple approvals and ready to merge! label Dec 1, 2023

Update packages/api-v4/src/account/account.ts

7a69aa5

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>

jaalah-akamai merged commit 0989de5 into linode:develop Dec 3, 2023

mjac0bs mentioned this pull request Dec 11, 2023

Release v1.108.0 - staging → master #9986

Merged

Conversation

jaalah-akamai commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Preview 📷

How to test 🧪

As an Author I have considered 🤔

Uh oh!

jaalah-akamai commented Nov 29, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaalah-akamai commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaalah-akamai commented Nov 29, 2023

Uh oh!

jaalah-akamai Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaalah-akamai commented Dec 1, 2023

Uh oh!

mjac0bs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jaalah-akamai commented Nov 29, 2023 •

edited

Loading

jaalah-akamai commented Nov 29, 2023 •

edited

Loading

jaalah-akamai Nov 30, 2023 •

edited

Loading