refactor: [M3-7509, M3-7518] TopMenu and TagsList v7 Stories#9948
refactor: [M3-7509, M3-7518] TopMenu and TagsList v7 Stories#9948abailly-akamai merged 3 commits intolinode:developfrom
Conversation
abailly-akamai
changed the title
| import { ColorPalette } from './ColorPalette'; | ||
|
|
||
| <Meta title="Core Styles/Color Palette" component={ColorPalette} /> | ||
| <Meta title="Design System/Color Palette" component={ColorPalette} /> |
There was a problem hiding this comment.
This is a bit more relevant a title, and will also push this category down. Eventually the design system will have its own storybook and it won't belong here, but for now we'll keep this page alive.
There was a problem hiding this comment.
We're removing the icons from storybook - unless a real list is kept up to date there's no reason to have this here. We usually get our icons straight from MUI anyway. See https://design.linode.com/?path=/docs/core-styles-icons-ui-icons--documentation, those icons are not accurate at all.
abailly-akamai
changed the title
abailly-akamai
requested review from
jaalah-akamai and
mjac0bs
and removed request for
a team
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Stories looked good.
I agree with your retitling of the Color Palette story and deletion of the outdated icons.
Thanks for removing mdx!
|
|
||
| /** | ||
| * - Items presented in the top navigation are considered universally important and should be available regardless of any particular task. | ||
| * - The number of items should be limited. In the future, **Help & Support** could become a drop down with links to **Community**, **Guides**, and etc. |
There was a problem hiding this comment.
In the future, Help & Support could become a drop down with links to Community, Guides, and etc.
I know this was existing copy, just ported over. I wonder if we have a ticket for this.
coliu-akamai
left a comment
coliu-akamai
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
✅ confirmed stories look good!
coliu-akamai
added
Approved
3 participants
Description 📝
Small PR to get rid of more
.mdxstories and replace them with a.tsxone when relevant.In this PR we are refactoring TopMenu & Tags stories and getting rid of icons since they are not relevant anymore.
This does not touch any client facing code.
Changes 🔄
.mdxstoriesPreview 📷
How to test 🧪
Verification steps
pull code locally and run
yarn storybookAs an Author I have considered 🤔
Check all that apply