test: [M3-6169] - Account cancellation integration tests#9952
Merged
jdamore-linode merged 5 commits intolinode:developfrom Dec 4, 2023
Merged
Conversation
added 3 commits
December 1, 2023 13:52
…l` mock utilities
…s between accordion headings and action buttons
jdamore-linode
requested review from
cliu-akamai
and removed request for
a team
jdamore-linode
commented
Dec 1, 2023
Comment on lines
+126
to
+130
| cy.wait('@cancelAccount').then((intercept) => { | ||
| expect(intercept.request.body['comments']).to.equal( | ||
| cancellationComments | ||
| ); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
@cliu-akamai, calling this out since you'll probably have to do something similar to confirm the Add User request payload contains the expected data for your M3-7482 ticket.
jdamore-linode
requested review from
cpathipa and
dwiley-akamai
and removed request for
a team
dwiley-akamai
approved these changes
Dec 1, 2023
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Code review ✅
account-cancellation.spec.ts passes locally ✅
| export const mockCancelAccountError = ( | ||
| errorMessage: string, | ||
| status: number = 400 | ||
| ) => { |
Contributor
There was a problem hiding this comment.
Should a Cypress.Chainable return type be added for this one as well?
Contributor
Author
There was a problem hiding this comment.
@dwiley-akamai Yep, thanks for catching that!
|
Coverage Report: ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This adds Cypress integration tests for various UI flows related to account cancellation via Cloud Manager's Account Settings page. Broadly speaking, these tests confirm that users can cancel their account, are correctly prompted to complete an exit survey, and that Cloud responds gracefully to API errors that occur during the cancellation process.
Changes 🔄
How to test 🧪
We can rely on CI to make sure that the tests pass and that changes made to mock utils and UI helpers do not cause any unintended issues.
To run the test locally, you can run
yarn && yarn build && yarn start:manager:ciand then run:yarn cy:run -s "cypress/e2e/core/account/account-cancellation.spec.ts"Alternatively, to run the tests interactively you can use
yarn cy:debugand search foraccount-cancellation.spec.ts.As an Author I have considered 🤔
Check all that apply