Skip to content

refactor: [M3-7532] - Payment Method Row Storybook v7 Story#9958

Merged
coliu-akamai merged 9 commits intolinode:developfrom
coliu-akamai:m3-7532
Dec 5, 2023
Merged

refactor: [M3-7532] - Payment Method Row Storybook v7 Story#9958
coliu-akamai merged 9 commits intolinode:developfrom
coliu-akamai:m3-7532

Conversation

@coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Dec 4, 2023 •
edited
Loading

Description 📝

  • MIgrate PaymentMethodRow component story to a V7 (.tsx) story

Changes 🔄

  • migrate to .tsx story
  • add tests for Delete payment method confirmation dialog
  • update imports/exports, switch to tss-mui

How to test 🧪

Prerequisites

Verification steps

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai self-assigned this Dec 4, 2023
@coliu-akamai coliu-akamai marked this pull request as ready for review December 4, 2023 20:26
@coliu-akamai coliu-akamai requested a review from a team as a code owner December 4, 2023 20:26
@coliu-akamai coliu-akamai requested review from cpathipa and jdamore-linode and removed request for a team December 4, 2023 20:26
@github-actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited
Loading

Coverage Report: ✅
Base Coverage: 85.63%
Current Coverage: 86.55%

bnussman-akamai
bnussman-akamai reviewed Dec 5, 2023
View reviewed changes
abailly-akamai
abailly-akamai approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

  • story renders well ✅
  • test look good and passing ✅

@coliu-akamai coliu-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Dec 5, 2023
bnussman-akamai
bnussman-akamai approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💳🎉

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 5, 2023
@coliu-akamai coliu-akamai merged commit 5623a50 into linode:develop Dec 5, 2023
@mjac0bs mjac0bs mentioned this pull request Dec 11, 2023
Merged
@coliu-akamai coliu-akamai deleted the m3-7532 branch December 19, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@jdamore-linode jdamore-linode Awaiting requested review from jdamore-linode jdamore-linode is a code owner automatically assigned from linode/cloud-manager-code-reviewers

@cpathipa cpathipa Awaiting requested review from cpathipa cpathipa is a code owner automatically assigned from linode/cloud-manager-code-reviewers

Assignees

@coliu-akamai coliu-akamai

Labels

Approved Multiple approvals and ready to merge! Storybook

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coliu-akamai @bnussman-akamai @abailly-akamai