test: Update notification language in test to correspond with API change#9972
Merged
jdamore-linode merged 2 commits intolinode:developfrom Dec 6, 2023
Conversation
jdamore-linode
requested review from
cliu-akamai
and removed request for
a team
jdamore-linode
requested review from
bnussman-akamai and
carrillo-erik
and removed request for
a team
bnussman-akamai
approved these changes
Dec 6, 2023
Member
bnussman-akamai
left a comment
bnussman-akamai
left a comment
There was a problem hiding this comment.
Looks good! That's pretty savage of the backend team to go for a lowercase l in linode.
| @@ -38,7 +38,7 @@ describe('resize linode', () => { | |||
|
|
|||
| // TODO: Unified Migration: [M3-7115] - Replace with copy from API '../notifications.py' | |||
Member
There was a problem hiding this comment.
Not related to this, but I noticed we kind of leaked some API code info here. Not a huge deal because it's super basic, but I think we generally try to avoid this.
Contributor
Author
There was a problem hiding this comment.
This is a good callout, thanks @bnussman-akamai -- I read these comments but didn't think twice about the code reference there. I know there's another reference to this code elsewhere in this spec, and it might be worthwhile doing a quick search to find any other API code references that might be lurking around.
|
Coverage Report: ✅ |
jdamore-linode
added
Add'tl Approval Needed
bnussman-akamai
added
Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixes the
resize-linode.spec.tstest by updating the notice string to match the language used by the API since the release of unified migrations.Changes 🔄
How to test 🧪
We can rely on CI for this, but to run the test locally you can use
yarn && yarn build && yarn start:manager:ci, and then:yarn cy:run -s "cypress/e2e/core/linodes/resize-linode.spec.ts"(Only the first test is modified by this PR, and it's the only test that's failing, so you don't have to wait for the entire spec to run since these are some of our most time consuming tests.)
As an Author I have considered 🤔
Check all that apply