linux: Add support to generate DH-HMAC-CHAP keys#158
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Jan 7, 2022
Merged
Conversation
igaw
force-pushed
the
nvme_gen_dhchap_key
branch
from
1c6334b to
8c28ade
Compare
Collaborator
Author
|
I can't get nvme-cli linking this as subproject. The linker is not adding libuuid, json-c nor openssl when tries to link. Something is not correctly setup with meson. |
Collaborator
Author
|
I think the problem is caused by libnvme getting the wrong 'config.h' as input. Not the the one from the subprojects instead the main one. |
igaw
force-pushed
the
nvme_gen_dhchap_key
branch
2 times, most recently
from
cc7550e to
726c19d
Compare
Collaborator
Author
|
Alright figured it out. Moving the config.h to libnvme is the right thing to do, but obviously, ccan was not happy. The trick is to use internal lookup path. Now things are working :) |
Merged
igaw
force-pushed
the
nvme_gen_dhchap_key
branch
from
726c19d to
0e1d56b
Compare
Initially the DH-HMAC-CHAP key generation code was part of the nvme-cli repository and depended on OpenSSL 1. Move the key generation code into the library. While at it also add support for OpenSSL 3. Signed-off-by: Daniel Wagner <dwagner@suse.de>
igaw
force-pushed
the
nvme_gen_dhchap_key
branch
from
0e1d56b to
436898e
Compare
Collaborator
Author
|
Just a rebase; checking if build is still good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially the DH-HMAC-CHAP key generation code was part of the
nvme-cli repository and depended on OpenSSL 1. Move the key generation
code into the library. While at it also add support for OpenSSL 3.
Signed-off-by: Daniel Wagner dwagner@suse.de