Merged
Conversation
Signed-off-by: Daniel Wagner <dwagner@suse.de>
In case the consuming project also uses a config.h we need to hide our config.h file. By using the path to our config.h we avoid this confusion. Obviously, 'src' is a bit too generic, thus move the generated config.h under libnvme. Introduce also a private include path because ccan has '#include "config.h"' in its sources. So we need to present a config.h in the lookup path but it needs to be the one from this project and not the one from the consuming project. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Use consistently _dep postfix for all dependency objects. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Currently, the Makefile is not setting the C dialect but the code was carved out from the nvme-cli code base which relies on gnu99. Let's define the C dialect to avoid any confusion and make the build more consistent. Without defining the default warning level the build system will use the default level, which is implementation depended. For example muon sets it to 3 which includes '-Wpendantic'. This results in a lot of ISO-C non compliant warnings. Let's define the warning level so that all build systems are using the same values. Signed-off-by: Daniel Wagner <dwagner@suse.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few more cleanups as a result from #158 and linux-nvme/nvme-cli#1293