Merged
Conversation
Collaborator
|
Can you please rebase this PR? There are conflicts due to recent changes. Thanks! |
sc108-lee
force-pushed
the
for-upstream/tp4095
branch
from
f11f666 to
ec10cf7
Compare
Contributor
Author
Collaborator
|
@hreinecke as this PR is changing the nvme_identify_args layout once again we should get this in soon. Any thoughts? |
Collaborator
|
@sc108-lee could you rebase and update it to the current HEAD. I suppose we should get this in now. |
sc108-lee
force-pushed
the
for-upstream/tp4095
branch
from
ec10cf7 to
1a1e2b0
Compare
Contributor
Author
|
@igaw rebased & added one more commit that remove domid from get log (using lsi field) |
CNS Specific identifier presents all names below for DWORD11 bits [15:00]
NVM Set Identifier(NVM Set List (04h))
Domain Identifier(Domain List (18h))
Endurance Group Identifier(Endurance Group List (19h))
Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Add uuid index argument on nvme_identify_ns_csi Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
09h - Identify Namespace data structure for the specified
User Data Format index containing the namespace capabilities
for the NVM Command Set.
0Ah - I/O Command Set specific Identify Namespace data structure
for the specified User Data Format index containing
the namespace capabilities for the I/O Command Set
specified in the CSI field.
Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
…md_id_ns Add explaination for mssrl, mcl, src Based on spec NVMe - TP 4095 Namespace Capability Reporting 2021.06.28 - Ratified
domid was not used in nvme_get_log as well Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
igaw
force-pushed
the
for-upstream/tp4095
branch
from
1a1e2b0 to
2803378
Compare
Collaborator
|
Collaborator
|
Hmm, I think I was too quick with the merge. The last patch looks strange: @@ -1846,8 +1831,7 @@ static inline int nvme_get_log_media_unit_stat(int fd, __u16 domid,
.len = sizeof(*mus),
.nsid = NVME_NSID_NONE,
.csi = NVME_CSI_NVM,
- .lsi = NVME_LOG_LSI_NONE,
- .domid = domid,
+ .lsi = domid,
.lsp = NVME_LOG_LSP_NONE,
.uuidx = NVME_UUID_NONE,
|
Collaborator
|
Just read up in the spec. I didn't expect that the Log Specific Identifier was overloaded. Your change looks correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added NVM Command Set id-ns
updates for TP 4095 Namespace Capability Reporting 2021.06.28 - Ratified