Merged
Conversation
Collaborator
|
I think the CI build is able to build against the matching libnvme commit. You just need to specify the matching ref in subprojects/libnvme.wrap. |
Collaborator
|
@MatiasBjorling you want probably to review this first :) |
742cdea to
44ec666
Compare
6f111a6 to
3070369
Compare
Contributor
Author
|
rebased and added one commit |
Include tp4095 changes Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
…md_id_ns Based on spec NVMe - TP 4095 Namespace Capability Reporting 2021.06.28 - Ratified Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Identify Namespace data structure for the specified User Data Format index containing the namespace capabilities for the NVM Command Set. None capabilities from nvme_id_ns structure are returned as 0 with this command Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
I/O Command Set specific Identify Namespace data structure for the specified LBA Format index for the NVM Command Set specified in the CSI field. None capabilities from nvme_id_ns structure are returned as 0 with this command Set maximum nlbaf when identify ns for all ns is failed to print elbafs Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
rename __nvme_show_id_ctrl -> nvme_show_id_ctrl Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
3070369 to
8ae1f92
Compare
Collaborator
|
Just reordered the commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on libnvme PR linux-nvme/libnvme#166
I was add these command into original id-ns, zns id-ns ...
But this command does not need NSID.
So I split this command as a new command.
if have any opinion for this, please let me know :)