Add setter and getter to track unique discovery controller#556
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Jan 20, 2023
Merged
Add setter and getter to track unique discovery controller#556igaw merged 1 commit intolinux-nvme:masterfrom
igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
igaw
force-pushed
the
add-unique-disc-ctrl
branch
from
fc41d35 to
ed5bd12
Compare
igaw
force-pushed
the
add-unique-disc-ctrl
branch
from
ed5bd12 to
8e067e1
Compare
igaw
force-pushed
the
add-unique-disc-ctrl
branch
from
8e067e1 to
f299576
Compare
Introduce a setter an getter to track if a discovery controller is unique (unique NQN as defined in TP8013). Signed-off-by: Daniel Wagner <dwagner@suse.de>
igaw
force-pushed
the
add-unique-disc-ctrl
branch
from
f299576 to
4292901
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds setter and getter for tracking unique discovery controller. The current library design is a bit awkward, as we have logic outside of the library and inside, so we end up exposing such APIs.