Additional Windows build support#3551
Merged
igaw merged 4 commits intoJul 7, 2026
Merged
Conversation
Enables compilation of plugins on Windows for plugins that compile successfully. Signed-off-by: Broc Going <bgoing@micron.com>
Adds support for statically linking required MinGW libraries when performing a static build on Windows. Signed-off-by: Broc Going <bgoing@micron.com>
When building with shared (dynamically linked) libraries on Windows, copies libnvme DLL into the build directory next to nvme.exe so it can be found at runtime without modifying PATH. Simplifies manual and automated testing of Windows builds. Signed-off-by: Broc Going <bgoing@micron.com>
Adds an environment setup script for the Windows MSYS2 UCRT64 build environment, and adds a section in the top level README.md regarding building on Windows. Signed-off-by: Broc Going <bgoing@micron.com>
igaw
reviewed
Jul 7, 2026
| 'plugins/micron/micron-nvme.c', | ||
| 'plugins/micron/micron-utils.c', | ||
| 'plugins/micron/micron-utils-win.c' | ||
| ], |
Collaborator
There was a problem hiding this comment.
I was starting to wonder why the micron shows up in both branches... the difference is micron-utils-linux.c vs micron-utils-win.c
For now this is okay. One thing we could do in future is to add a meson.build to each plugin if this helps to make it a bit more streamlined.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes add the rest of the build support required for Windows and adds information and a helper utility for configuring a build system on Windows.