solidigm: fix unchecked return value in solidigm_config_get_nlog_formats() - #3777
Merged
Merged
Conversation
…ats() The solidigm_config_get_nlog_formats() function looks up the "NLOG_FORMATS" key from the JSON config object using json_object_object_get_ex(). The return value of the call was not checked. If "NLOG_FORMATS" is absent from the config, the lookup silently fails and @nlog_formats remains NULL. While the caller guards against a NULL return, the function itself makes no distinction between a successful lookup that returned NULL and a failed one, violating the consistent error-checking contract of the codebase. Check the return value and return NULL explicitly when the key is not found to make the error path consistent with all other call sites. Signed-off-by: Sarah Ahmed <sarah.ahmed@ibm.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The solidigm_config_get_nlog_formats() function looks up the "NLOG_FORMATS" key from the JSON config object using json_object_object_get_ex(). The return value of the call was not checked.
If "NLOG_FORMATS" is absent from the config, the lookup silently fails and nlog_formats remains NULL. While the caller guards against a NULL return, the function itself makes no distinction between a successful lookup that returned NULL and a failed one, violating the consistent error-checking contract of the codebase.
Check the return value and return NULL explicitly when the key is not found to make the error path consistent with all other call sites.