travis: Enforce kernel coding style on rdma-core#168
Merged
Conversation
rleon
force-pushed
the
topic/add-checkpatch-to-travis
branch
from
9d7b953 to
6877c5f
Compare
The rdma-core library is tightly coupled to the linux-rdma kernel and developed mostly by the same kernel developers. Enforcement of the same coding style as used for kernel development has potential to reduce errors and improve readability. Despite the fact that checkpatch is written as general tool, the differences between kernel and user space requires from us to skip kernel types, file movement and execute permissions checks. Signed-off-by: Leon Romanovsky <leon@kernel.org>
rleon
force-pushed
the
topic/add-checkpatch-to-travis
branch
from
6877c5f to
ecc5ff0
Compare
Member
Author
|
@dledford thanks @jgunthorpe it is actually checks for SOB in the patches without need to install anything. |
Member
|
Lets see how it goes.. checkpatch is often strangely opinionated.. |
Member
|
This aborts travis for any sparse warnings, not just errors, so I don't think it is really going to work well enough as is.. eg I re-based the #165 to trigger this new check and see how it goes off the rails with warnings. |
Member
Author
|
@jgunthorpe , I see. We can ignore warnings and fail for errors only |
Member
Author
|
But it is bad, I don't know if we catch something with such limited check |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rdma-core library is tightly coupled to the linux-rdma kernel
and developed mostly by the same kernel developers. Enforcement of
the same coding style as used for kernel development has potential
to reduce errors and improve readability.
Despite the fact that checkpatch is written as general tool, the
differences between kernel and user space requires from us to
skip kernel types, file movement and execute permissions checks.
Signed-off-by: Leon Romanovsky leon@kernel.org