Skip to content

Sparse fixes from Christoph Hellwig #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rleon merged 42 commits into from
Oct 15, 2016
Merged

Sparse fixes from Christoph Hellwig #19

rleon merged 42 commits into from
Oct 15, 2016

Conversation

@jgunthorpe
Copy link
Member

@jgunthorpe jgunthorpe commented Oct 13, 2016

These are just the first 15 that made it to the list, will update this branch with the rest when they are sent.

Christoph Hellwig added 30 commits October 13, 2016 12:42
@jgunthorpe
libibumad: include umad_str.h in umad_str.c
ec5935b 
So that we have the prototypes available in the implementation file
and do get proper type checking for them.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hal Rosenstock <hal@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
libibumad: create sysfs.h instead of using extern declarations in umad.c
01636db 
So that we have the prototypes available in the implementation file
and do get proper type checking for them.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hal Rosenstock <hal@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
libibumad: use NULL instead of 0 for NULL pointers
878a01d 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hal Rosenstock <hal@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
libibumad: mark symbols as static where possible
e28771d 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hal Rosenstock <hal@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
srp_daemon: use NULL instead of 0 for NULL pointers
5e64c5f 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
srp_daemon: mark symbols as static where possible
27a47e6 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
srp_daemon: give initialize_sysfs a proper ANSI-C prototype
267d8c7 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
iwpmd: fix the prototype for the pthread_create start functions
23e6da9 
And also remove the unessecary taking of the address for function
arguments while we're at it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
iwpmd: use proper ANSI-C prototypes for functions without arguments
3c7a735 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
iwpmd: remove the unused check_iwpm_nlattr_tb prototype
4dacf18 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
iwpmd: move external declarations to iwarp_pm.h
d6f9db6 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
iwpmd: mark symbols static where possible
b9cb26d 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
librdmacm: mark symbols static where possible
8177532 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
cxgb4: mark symbols static where possible
81c9f14 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
cxgb4: remove unused function dump_wqe
7d1ca23 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
cxgb3: handle global variables properly
ee12a43 
We'll need to define them in one compilation unit and use an extern
declaration in the headers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
cxgb3: mark symbols static where possible
ead9565 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
hfi1verbs: mark symbols static where possible
ada5ad4 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
ipathverbs: mark symbols static where possible
65b5c40 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
i40iw: mark symbols static where possible
d2430a5 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
i40iw: remove unused variable i40iw_debug_level
191db75 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
mlx4: mark symbols static where possible
be6d446 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
mthca: mark symbols static where possible
5b35c14 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
rxe: mark symbols static where possible
e402ee2 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
ocrdma: mark symbols static where possible
c0cbba5 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
ocrdma: use NULL instead of 0 for NULL pointers
2755229 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
nes: move external declaration to nes_umain.h
4f981ca 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
nes: mark symbols static where possible
5be53c7 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
nes: use NULL instead of 0 for NULL pointers
fddd70d 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
mlx5: mark symbols static where possible
aa84f86 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Christoph Hellwig added 2 commits October 13, 2016 17:54
@jgunthorpe
mlx5: use NULL instead of 0 for NULL pointers
5d85ff0 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
mlx5: use proper ANSI-C prototypes for functions without arguments
83b728e 
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe jgunthorpe force-pushed the sparse1 branch 3 times, most recently from 954cf0a to 76882c6 Compare October 14, 2016 18:23
@jgunthorpe
Enable -Wstrict-prototypes/-Wold-style-definition
4706c63 
All bad cases are fixed now. This is useful to detect non-ISO
function signatures which use surprising and counter intuitive
rules.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
Enable -Wmissing-prototypes/-Wmissing-declarations
b192ed2 
This is useful to detect functions which probably should be static.

One wrinkle is the use of .symver macros in verbs. These require
non-static definitions that cannot have the same name as the public
prototype. Locally disable the warning to deal with that.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
rdmacm: constify rdma_getaddrinfo public function
1328087 
Like getaddrinfo most of the arguments should be const.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
Enable -Wwrite-strings
44579ae 
The is useful to detect possible writing to read only memory.

The compiler places strings in .rodata so they are unwritable and
are technically const.

Add consts as necessary, no casts were added so this should be safe.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
verbs: Use cmake to detect if net/if.h vs netling/route/link.h is broken
dc386fc 
If not then just use the header directly, otherwise use the work around.

The issue is that old libnl libraries include linux/if.h and the
declarations there conflict with net/if.h. New libraries do not
do this.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
Enable -Wredundant-decls
c93346d 
This is useful to detect possible confusion/mistakes around function
prototypes.

Old libnl includes such a mistake so this warning is only turned on with
new distros.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
acm: Fix wrong format attributes for error
89712aa 
The arguments were swapped, and totally crash-when-run wrong.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
acm: Fix format string usage with acm_log
1732bcb 
Enable format string checking for acm_write and clean up everything.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
Enable -Wformat=2
a7407da 
This is useful to detect functions that are handling format strings but
not marked with __attribute__(format), as well as other sorts
for format related mistakes.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
Enable -Wshadow
ccf6122 
Having multiple objects with the same name in the same scope is
almost always confusing. Make some trivial changes to avoid those
few cases.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
@jgunthorpe
Copy link
Member Author

jgunthorpe commented Oct 14, 2016

I think this is done for now

@rleon rleon merged commit a7ede66 into linux-rdma:master Oct 15, 2016
@jgunthorpe jgunthorpe deleted the sparse1 branch October 15, 2016 16:15
jgunthorpe pushed a commit to jgunthorpe/rdma-plumbing that referenced this pull request Feb 19, 2019
@weiny2
Merge pull request linux-rdma#19 from cyrilleverrier/patch-1
ddf29e7 
Update README: list python dependencies (docutils)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jgunthorpe @rleon