Skip to content

Conversation

@rleon
Copy link
Member

@rleon rleon commented Oct 15, 2016

These five patches is what I came up with after having had a look at the
rxe_cfg source code.

Bart Van Assche added 5 commits October 15, 2016 12:32
…mmands

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
This patch avoids that the following error message is printed if
ibv_devinfo fails:

Use of uninitialized value $rmtu in string at /usr/local/bin/rxe_cfg line 364.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Suppressing stderr if stdout is already redirected is wrong. Hence
do not suppress stderr. If e.g. the ib_uverbs kernel module is not
loaded, without this patch no error messages are printed. With this
patch applied the following is printed:

Failed to get IB devices list: Function not implemented

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
@rleon rleon merged commit a2e76f6 into linux-rdma:master Oct 15, 2016
@rleon rleon deleted the rxe-cfg-fixes branch October 15, 2016 09:37
jgunthorpe pushed a commit to jgunthorpe/rdma-plumbing that referenced this pull request Feb 19, 2019
Add latest Bull device IDs to device white lists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant