media: intel/ipu-bridge: fix OVTID858 link frequencies - #174
Open
zR-JB wants to merge 1 commit into
Open
Conversation
This was referenced Aug 12, 2026
zR-JB
marked this pull request as ready for review
August 12, 2026 21:14
The OVTID858 configuration currently sets nr_link_freqs to 4 while providing only a single 540 MHz value. The second IPU_SENSOR_CONFIG argument is the number of link frequencies, not the CSI lane count; the lane count is obtained separately from firmware SSDB. The OV13858 driver exposes two link frequencies, 540 MHz and 270 MHz, and uses both across its supported modes. Publish those two frequencies in the OVTID858 bridge configuration instead. The entry was originally annotated for Surface Pro 9, but OVTID858 is also used by later Surface Pro generations, so make the sensor comment device-independent. The 540/270 MHz configuration was independently tested successfully with the OV13858 rear camera on Surface Pro 12 Intel. Signed-off-by: Jan Baisch <jan.baisch@protonmail.com> Link: linux-surface#174 Patchset: cameras
zR-JB
force-pushed
the
ovtid858-link-frequencies
branch
from
August 12, 2026 21:37
0085f0f to
3574c89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
OVTID858/ OV13858 entry inipu-bridgeto publish the two link frequencies supported by the OV13858 driver.The existing entry is:
The second argument to
IPU_SENSOR_CONFIG()isnr_link_freqs, not the CSI lane count. The bridge obtains the actual lane count separately from firmware SSDB.The OV13858 driver itself exposes exactly two link frequencies, 540 MHz and 270 MHz, in its
LINK_FREQcontrol menu, and uses those two entries across its supported modeskernel/drivers/media/i2c/ov13858.c
Lines 992 to 1038 in 7d3b315
Reflect that in the bridge configuration:
The entry was originally annotated for Surface Pro 9, but OVTID858 is also used by later Surface Pro generations, so make the comment device-independent.
Testing
The 540/270 MHz configuration was independently used successfully while enabling the OV13858 rear camera on Surface Pro 12 Intel.
The existing linux-surface OV13858 support was also separately confirmed to probe and stream the same camera on Surface Pro 12 Intel.
Related Surface Pro 12 enablement tracking: linux-surface/linux-surface#2144.
Related Surface Pro 12 camera work