Added examples of options in Readme#58
Conversation
vrindle
force-pushed
the
add_examples_to_readme
branch
2 times, most recently
from
b8bd891 to
076b4e9
Compare
| set both permanent and runtime to `false`. | ||
|
|
||
| Examples of Options | ||
| ------------------- |
There was a problem hiding this comment.
Since the default is permanent: yes and runtime: yes I think you can omit them from the examples, and say something like "By default, any changes will be applied immediately, and to the permanent settings. If you want the changes to apply immediately but not permanently, use permanent: no. Conversely, use runtime: no".
| Permit TCP traffic for port 80 in permanent default zone: | ||
|
|
||
| ```yaml | ||
| firewall: |
There was a problem hiding this comment.
The firewall role firewall variable value is a list - so this should be
firewall:
- port: 80/tcp
state: enabledI note that there are some corrections we need to make in the role README as well - like https://github.com/linux-system-roles/firewall#state
https://github.com/linux-system-roles/firewall#example-playbooks
and in "It is also possible to combine several settings into blocks:" there are a couple of extraneous dashes - in the left hand column.
Also, the README https://github.com/linux-system-roles/firewall#variables section should start off with something like
The firewall role uses the variable `firewall` to specify the parameters. This variable is a `list` of `dict` values. Each `dict` value is comprised of one or more keys listed below.
16c3dac to
382f676
Compare
| ```yaml | ||
| firewall: | ||
| - masquerade: yes | ||
| zone: dmz |
There was a problem hiding this comment.
state is a required parameter - please add state: enabled here
| ```yaml | ||
| firewall: | ||
| - masquerade: no | ||
| zone: dmz |
There was a problem hiding this comment.
state is a required parameter - please add state: disabled here
There was a problem hiding this comment.
I think the state would have to be set to state: enabled here since masquerading cannot be used with the state being set to disabled.
firewall/library/firewall_lib.py
Line 403 in 94e0c6d
vrindle
force-pushed
the
add_examples_to_readme
branch
from
382f676 to
6d38ee5
Compare
2 participants
No description provided.