Add firewalld "zone" variable for connections#22
Merged
Conversation
thom311
added a commit
that referenced
this pull request
Jan 17, 2018
Contributor
|
Nice. Thanks!! I merged it, with a follow-up fix. I think the validation of the user configuration should be strict, hence, 'zone' should be rejected for slaves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this is one of the variables requested by #9 (
ZONE).I ran into this because using both this network role in initscripts mode together with e.g.
would cause Ansible to report changes on every run of my playbook. By just having this role set the firewalld zone in the
ifcfg-eth0file, I can skip using the firewalld module at all, and no more spurious changes as this role and the firewalld module fight over theifcfg-eth0file.I did not test this on a system whose interfaces are actually managed by NetworkManager, though I did run the unit tests on a system with the NM Python APIs installed, and all passed. Though I'm not entirely sure that I have updated the unit tests to everyone's liking.