Specify Python 2 for LGTM#62
Merged
dwlehman merged 2 commits intolinux-system-roles:masterfrom Nov 14, 2019
Merged
Conversation
LGTM defaults to Python 3 for the storage role because it was created recently. Since it needs to support Python 2 as well, configure it explicitly.
Contributor
|
This pull request introduces 2 alerts when merging fd08008 into 378239c - view on LGTM.com new alerts:
|
The @Property decorator requires a new-style class in Python 2, see https://lgtm.com/rules/10030086/
Member
|
@i386x could you please get it into the CI template (PR linux-system-roles/template#5 )? |
Member
Author
Contributor
Done in linux-system-roles/template@427866f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LGTM defaults to Python 3 for the storage role because it was created
recently. Since it needs to support Python 2 as well, configure it
explicitly.
LGTM is a static code analyzer to identify bugs in code, it found real issues that I fixed in PR #52.
This change is