Skip to content

chore: disable cppcheck CI for treeland-protocols and fix typo (branc… - #801

Merged
BLumia merged 1 commit into
linuxdeepin:masterfrom
wineee:tp
Aug 7, 2026
Merged

chore: disable cppcheck CI for treeland-protocols and fix typo (branc…#801
BLumia merged 1 commit into
linuxdeepin:masterfrom
wineee:tp

Conversation

@wineee

@wineee wineee commented Aug 7, 2026

Copy link
Copy Markdown
Member

…he -> branches)

Summary by Sourcery

Disable cppcheck CI for the treeland-protocols repository and correct a typo in its configuration metadata.

CI:

  • Disable cppcheck checks for the linuxdeepin/treeland-protocols repository in the CI configuration.

Chores:

  • Fix a typo in the linuxdeepin/treeland-protocols repository configuration metadata.

@sourcery-ai

sourcery-ai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Disables cppcheck CI for the treeland-protocols repository configuration and fixes a minor typo in its metadata.

File-Level Changes

Change Details Files
Disable cppcheck CI for treeland-protocols in repo config
  • Update repository configuration to turn off cppcheck CI for treeland-protocols
  • Ensure the CI configuration no longer schedules or triggers cppcheck for this repo
repos/linuxdeepin/treeland-protocols.json
Fix typo in treeland-protocols repo metadata
  • Correct a spelling error in the branches description field ("he" -> "branches" or similar textual fix)
repos/linuxdeepin/treeland-protocols.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

…he -> branches)

Log: treeland-protocols is not a cpp project
also remove non-existent branches, keep only master
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码修复了配置文件中的键名拼写错误并清理了废弃配置,质量极高
逻辑完全正确且无任何安全风险,无需扣分

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

修正了原文件中第二项的 "branche" 和第四项的 "branches""branch",消除了因键名不一致导致的解析遗漏风险,JSON 语法严谨无误。
建议:保持现有的配置校验机制,防止后续新增配置时再次出现拼写错误。

  • 2.代码质量(优秀)✓

移除了已结束生命周期的 develop/sniperelease/snipe 分支配置,删除了废弃的 cppcheck.yml 同步项,并清理了文件末尾多余空行,配置文件结构清晰、整洁。
建议:继续维持这种及时清理废弃配置的习惯。

  • 3.代码性能(无性能问题)✓

静态 JSON 配置文件体积微小,解析开销可忽略不计,无任何性能瓶颈。
建议:无需优化。

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
总体风险描述:无安全风险,配置文件仅包含静态工作流同步路径和分支声明,不涉及敏感信息泄露或外部输入解析。

  • 建议:无需修复。

■ 【改进建议代码示例】

[
  {
    "branch": [
      "master"
    ],
    "src": "workflow-templates/call-clacheck.yml",
    "dest": "linuxdeepin/treeland-protocols/.github/workflows/call-clacheck.yml"
  },
  {
    "branch": [
      "master"
    ],
    "src": "workflow-templates/call-commitlint.yml",
    "dest": "linuxdeepin/treeland-protocols/.github/workflows/call-commitlint.yml"
  },
  {
    "branch": [
      "master"
    ],
    "src": "workflow-templates/call-chatOps.yml",
    "dest": "linuxdeepin/treeland-protocols/.github/workflows/call-chatOps.yml"
  },
  {
    "branch": [
      "master"
    ],
    "src": "workflow-templates/call-license-check.yml",
    "dest": "linuxdeepin/treeland-protocols/.github/workflows/call-license-check.yml"
  }
]

@wineee
wineee requested review from BLumia and zccrs August 7, 2026 02:34
@BLumia
BLumia merged commit 2ccfc1f into linuxdeepin:master Aug 7, 2026
6 checks passed
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wineee

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wineee
wineee deleted the tp branch August 7, 2026 02:36
zccrs pushed a commit to linuxdeepin/treeland-protocols that referenced this pull request Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants