fix: close popups before showing launchpad

[18202781743]

Summary by Sourcery

Bug Fixes:

• Prevent the launcher from becoming visible while other Qt popups are still active by deferring its display until popups are closed.

[sourcery-ai]

Sorry @18202781743, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[sourcery-ai]

Reviewer's Guide

Implements deferred launcher visibility changes to ensure all Qt popups are closed and their Wayland grabs released before showing the launchpad, using a pending-show flag and a zero-timeout timer callback.

Sequence diagram for deferred launcher visibility when popups are open

sequenceDiagram
    participant Caller
    participant LauncherController
    participant QGuiApplicationPrivate
    participant QTimer

    Caller->>LauncherController: setVisible(true)
    LauncherController->>QGuiApplicationPrivate: popupCount()
    QGuiApplicationPrivate-->>LauncherController: popupCount > 0
    LauncherController->>LauncherController: m_showPending = true
    LauncherController->>LauncherController: closeAllPopups()
    LauncherController->>QTimer: singleShot(0, this, lambda)

    QTimer-->>LauncherController: lambda callback
    alt m_showPending is true
        LauncherController->>LauncherController: m_showPending = false
        LauncherController->>LauncherController: setVisible(true)
    else m_showPending is false
        LauncherController->>LauncherController: [return]
    end

Loading

File-Level Changes

Change	Details	Files
Guard launcher visibility changes with a pending-show flag and defer showing until after popups are closed.	Return early when hiding while a pending show is scheduled, cancelling the pending show instead Avoid redundant visibility changes by returning when the requested visibility matches the current state or when a show is already pending When a show is requested while any Qt popups are open, mark the show as pending, close all popups, and schedule a deferred visibility change using QTimer::singleShot In the deferred callback, re-check the pending flag, clear it, and call setVisible(true) to actually show the launcher	launchercontroller.cpp
Extend launcher controller state to track pending show requests and update copyright metadata.	Add a new m_showPending boolean member, initialized to false, to track deferred show operations Update the SPDX-FileCopyrightText year range to 2023 - 2026	launchercontroller.h

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[18202781743]

在x11和wayland下，任务栏上的右键菜单弹出后，再用快捷键启动小启动器，菜单不消失，
在treeland下，小启动器位置还会错误，

[deepin-ci-robot]

deepin pr auto review

★ 总体评分：85分

■ 【总体评价】

代码实现了Wayland下弹出窗口抓取释放的延迟显示逻辑，但使用了Qt私有API
逻辑正确但因依赖私有接口导致兼容性风险扣15分

■ 【详细分析】

• 1.语法逻辑（基本正确）✓

在LauncherController::setVisible函数中，通过m_showPending标志位和QTimer::singleShot(0)实现了状态机的正确流转，有效处理了在延迟显示期间取消显示的边界情况
潜在问题：若在QTimer::singleShot(0)触发瞬间有新的弹出窗口产生，popupCount可能仍大于0，但概率极低
建议：在QTimer::singleShot(0)的回调中增加二次检查弹出窗口数量的逻辑，若仍大于0则继续延迟

• 2.代码质量（一般）✕

代码引入了m_showPending状态变量且注释清晰，但直接调用了QGuiApplicationPrivate::popupCount()，该接口属于Qt的私有API，未在官方公共头文件中导出
潜在问题：依赖私有API会导致在Qt版本升级（如从Qt5升级到Qt6）时面临编译失败或运行时符号找不到的风险
建议：尽量避免直接使用私有API，可通过遍历QGuiApplication::topLevelWidgets()检测带Qt::Popup标志的窗口数量，或向Qt官方提需求暴露公共接口

• 3.代码性能（无性能问题）✓

使用QTimer::singleShot(0)将显示操作推迟到当前事件循环结束后，仅增加极小的事件队列开销，closeAllPopups()为必要的清理操作，整体无性能损耗
建议：保持现状即可

• 4.代码安全（存在0个安全漏洞）✓

漏洞对比统计：新增漏洞 0 个，减少漏洞 0 个，持平 0 个
代码仅涉及UI状态控制和事件循环调度，未涉及内存越界、命令注入、权限提升等安全风险面

• 建议：保持现有的安全编码水平，注意后续迭代中的内存管理

■ 【改进建议代码示例】

void LauncherController::setVisible(bool visible)
{
    if (!visible && m_showPending) {
        m_showPending = false;
        return;
    }

    if (visible == m_visible || (visible && m_showPending)) return;

    // 替换私有API调用，通过遍历顶层窗口检测Popup
    auto getPopupCount = []() {
        int count = 0;
        const auto topWidgets = QGuiApplication::topLevelWidgets();
        for (QWidget *w : topWidgets) {
            if (w->windowType() == Qt::Popup && w->isVisible()) {
                ++count;
            }
        }
        return count;
    };

    if (visible && getPopupCount() > 0) {
        m_showPending = true;
        closeAllPopups();

        // Let Qt finish hiding the current popup and release the Wayland
        // popup grab before the launcher window is mapped.
        QTimer::singleShot(0, this, [this, getPopupCount] {
            if (!m_showPending) {
                return;
            }

            // 增加二次检查，防止极端情况下新的Popup产生
            if (getPopupCount() > 0) {
                QTimer::singleShot(0, this, [this] {
                    if (!m_showPending) return;
                    m_showPending = false;
                    setVisible(true);
                });
                return;
            }

            m_showPending = false;
            setVisible(true);
        });
        return;
    }

    m_visible = visible;
    // ... (后续原有逻辑)
}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment