fix: update Accounts D-Bus interface names to org.deepin.dde.Accounts1 - #600
Conversation
1. Replace com.deepin.daemon.Accounts with org.deepin.dde.Accounts1 in accountInterface() for both service name and interface names 2. Ensures D-Bus calls match the renamed account service on V25, preventing lookup failures during rollback/boot procedures PMS: BUG-373169 Log: update Accounts D-Bus interface names to org.deepin.dde.Accounts1 Influence: 1. 升级系统后执行回退流程,验证能否正常进入桌面 2. 控制中心-系统-启动菜单-启动设置中选择回退并重启,验证系统正常启动 fix: 更新 Accounts D-Bus 接口名为 org.deepin.dde.Accounts1 1. 将 accountInterface() 中的 com.deepin.daemon.Accounts 替换为 org.deepin.dde.Accounts1,同步更新服务名和接口名 2. 确保 D-Bus 调用与 V25 上重命名后的账户服务一致, 避免回退/启动过程中查找失败 PMS: BUG-373169 Log: 更新 Accounts D-Bus 接口名为 org.deepin.dde.Accounts1 Influence: 1. 升级系统后执行回退流程,验证能否正常进入桌面 2. 控制中心-系统-启动菜单-启动设置中选择回退并重启,验证系统正常启动
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the D-Bus service and interface names used by NetworkInitialization::accountInterface to align with the renamed Accounts service org.deepin.dde.Accounts1, ensuring account lookups work correctly on V25 during rollback and boot flows. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, fly602 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin pr auto review★ 总体评分:95分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 diff --git a/network-service-plugin/src/system/networkinitialization.cpp b/network-service-plugin/src/system/networkinitialization.cpp
index 06de55913..safe_account_iface 100755
--- a/network-service-plugin/src/system/networkinitialization.cpp
+++ b/network-service-plugin/src/system/networkinitialization.cpp
@@ -303,11 +303,17 @@ QVariant NetworkInitialization::accountInterface(const QString &path, const QStr
{
QString interfaceName;
if (isUser) {
interfaceName = "org.deepin.dde.Accounts1.User";
} else {
interfaceName = "org.deepin.dde.Accounts1";
}
QDBusInterface dbus("org.deepin.dde.Accounts1", path, interfaceName, QDBusConnection::systemBus());
+
+ if (!dbus.isValid()) {
+ qCWarning(networkLog) << "Failed to create DBus interface for" << path
+ << dbus.lastError().message();
+ return QVariant();
+ }
+
return dbus.property(key.toLocal8Bit().constData());
} |
PMS: BUG-373169
Log: update Accounts D-Bus interface names to org.deepin.dde.Accounts1
Influence:
fix: 更新 Accounts D-Bus 接口名为 org.deepin.dde.Accounts1
PMS: BUG-373169
Log: 更新 Accounts D-Bus 接口名为 org.deepin.dde.Accounts1
Influence:
Summary by Sourcery
Bug Fixes: