fix(auth-password): reset password field state on reset#72
Conversation
1. Reset password input echo mode to Password on reset 2. Reset password visibility button icon to "shown" state Log: Fix password field not resetting to obscured state and toggle button icon when reset is called fix(auth-password): 重置时恢复密码字段状态 1. 重置时恢复密码输入框的密文显示模式 2. 重置时恢复密码可见性切换按钮的图标为"可见"状态 Log: 修复重置密码字段时未恢复密文模式和按钮图标的问题 PMS: BUG-368397
|
Hi @MyLeeJiEun. Thanks for your PR. 😃 |
|
Hi @MyLeeJiEun. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideResets the password input field and visibility toggle button to their default obscured state when AuthPassword::reset() is called, ensuring consistent UI and security behavior after a reset. Sequence diagram for AuthPassword::reset restoring password field statesequenceDiagram
actor User
participant AuthPassword
participant m_lineEdit
participant m_passwordShowBtn
User->>AuthPassword: reset()
AuthPassword->>m_lineEdit: setAlert(false)
AuthPassword->>m_lineEdit: hideAlertMessage()
AuthPassword->>m_lineEdit: setEchoMode(QLineEdit::Password)
AuthPassword->>m_passwordShowBtn: setIcon(QIcon(PASSWORD_SHOWN))
AuthPassword->>AuthPassword: hidePasswordHintWidget()
AuthPassword->>AuthPassword: setLineEditEnabled(true)
AuthPassword->>AuthPassword: setLineEditInfo(tr(Password), PlaceHolderText)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- When resetting the echo mode and button icon, make sure any internal state flag that tracks password visibility (if present) is also reset so the UI and logic stay in sync after
reset(). - Consider encapsulating the "default password visibility" setup (echo mode + icon) into a small helper method and reuse it here and wherever the initial state is configured, to avoid diverging defaults over time.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- When resetting the echo mode and button icon, make sure any internal state flag that tracks password visibility (if present) is also reset so the UI and logic stay in sync after `reset()`.
- Consider encapsulating the "default password visibility" setup (echo mode + icon) into a small helper method and reuse it here and wherever the initial state is configured, to avoid diverging defaults over time.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#72
Log: Fix password field not resetting to obscured state and toggle button icon when reset is called
fix(auth-password): 重置时恢复密码字段状态
Log: 修复重置密码字段时未恢复密文模式和按钮图标的问题
PMS: BUG-368397
Summary by Sourcery
Reset password field visibility state when the auth password widget is reset.
Bug Fixes: