fix(settings): use combo box for photo format#507
Open
Resurgamz wants to merge 1 commit into
Open
Conversation
Replace the read-only photo format label with the standard settings combo box. The photo output format now exposes a single JPG option, keeping the control consistent with other output settings and allowing future formats to be added without another UI rewrite. Remove the obsolete formatLabel widget registration, implementation, and accessibility identifier. Validation: JSON syntax check, static reference check, and git diff --check. Related: BUG-156865
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Resurgamz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReplaces the custom read-only photo format label widget with the standard settings combo box configuration, exposing a single JPG option and cleaning up obsolete widget registration and accessibility identifiers. State diagram for photo format setting UI changestateDiagram-v2
state PhotoFormatSettingUI {
ReadOnlyFormatLabel
ComboBoxFormatOption
}
ReadOnlyFormatLabel --> ComboBoxFormatOption : settings_json_updated
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the read-only photo format label with the standard settings combo box.
The photo output format now exposes a single JPG option, keeping the control consistent with other output settings and allowing future formats to be added without another UI rewrite.
Remove the obsolete formatLabel widget registration, implementation, and accessibility identifier.
Validation: JSON syntax check, static reference check, and git diff --check.
Related: BUG-156865
Summary by Sourcery
Replace the photo format settings label with a standard combo box control and remove the obsolete label widget wiring.
New Features:
Enhancements: