[deepin-compressor] Updates for project Deepin Archive Manager#424
Open
transifex-integration[bot] wants to merge 1 commit into
Open
[deepin-compressor] Updates for project Deepin Archive Manager#424transifex-integration[bot] wants to merge 1 commit into
transifex-integration[bot] wants to merge 1 commit into
Conversation
100% translated source file: 'deepin-compressor.ts' on 'cs'.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: transifex-integration[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @transifex-integration[bot]. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's GuideUpdates the Czech (cs) translation file for Deepin Archive Manager, adding translations for newly introduced UI strings, completing previously unfinished entries, and adjusting some existing translations and XML metadata to align with current source code and terminology. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="translations/deepin-compressor_cs.ts" line_range="4" />
<code_context>
<location filename="../3rdparty/interface/queries.cpp" line="521"/>
<source>Cancel</source>
<comment>button</comment>
- <translation>Storno</translation>
+ <translation>Zrušit</translation>
</message>
</context>
</code_context>
<issue_to_address>
**suggestion:** Translation of the "Cancel" button is now inconsistent with other "Cancel" translations in this file.
This instance uses "Zrušit" while other `Cancel` buttons in the same TS file still use "Storno" (e.g., in `popupdialog.cpp` and other `queries.cpp` entries). Please standardize on one form across the UI—either update the remaining "Storno" translations to "Zrušit", or keep this as "Storno" for consistency.
```suggestion
<message>
<location filename="../3rdparty/interface/queries.cpp" line="521"/>
<source>Cancel</source>
<comment>button</comment>
<translation>Storno</translation>
</message>
```
</issue_to_address>
### Comment 2
<location path="translations/deepin-compressor_cs.ts" line_range="420-423" />
<code_context>
<location filename="../src/source/dialog/popupdialog.cpp" line="670"/>
<source>Cancel</source>
<comment>button</comment>
- <translation type="unfinished">Storno</translation>
+ <translation>Zrušit</translation>
</message>
<message>
</code_context>
<issue_to_address>
**suggestion:** Another "Cancel" button translation changed to "Zrušit" while others remain "Storno".
Please align this label with the other `Cancel` buttons in the file (e.g., `queries.cpp:397`) so they all use the same Czech term, either "Zrušit" or "Storno", for consistency.
```suggestion
<location filename="../3rdparty/interface/queries.cpp" line="521"/>
<source>Cancel</source>
<comment>button</comment>
<translation>Storno</translation>
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <?xml version="1.0" ?><!DOCTYPE TS><TS version="2.1" language="cs"> | ||
| <context> | ||
| <name>AppendDialog</name> | ||
| <message> |
There was a problem hiding this comment.
suggestion: Translation of the "Cancel" button is now inconsistent with other "Cancel" translations in this file.
This instance uses "Zrušit" while other Cancel buttons in the same TS file still use "Storno" (e.g., in popupdialog.cpp and other queries.cpp entries). Please standardize on one form across the UI—either update the remaining "Storno" translations to "Zrušit", or keep this as "Storno" for consistency.
Suggested change
| <message> | |
| <message> | |
| <location filename="../3rdparty/interface/queries.cpp" line="521"/> | |
| <source>Cancel</source> | |
| <comment>button</comment> | |
| <translation>Storno</translation> | |
| </message> |
Comment on lines
420
to
+423
| <location filename="../3rdparty/interface/queries.cpp" line="521"/> | ||
| <source>Cancel</source> | ||
| <comment>button</comment> | ||
| <translation>Storno</translation> | ||
| <translation>Zrušit</translation> |
There was a problem hiding this comment.
suggestion: Another "Cancel" button translation changed to "Zrušit" while others remain "Storno".
Please align this label with the other Cancel buttons in the file (e.g., queries.cpp:397) so they all use the same Czech term, either "Zrušit" or "Storno", for consistency.
Suggested change
| <location filename="../3rdparty/interface/queries.cpp" line="521"/> | |
| <source>Cancel</source> | |
| <comment>button</comment> | |
| <translation>Storno</translation> | |
| <translation>Zrušit</translation> | |
| <location filename="../3rdparty/interface/queries.cpp" line="521"/> | |
| <source>Cancel</source> | |
| <comment>button</comment> | |
| <translation>Storno</translation> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following localization files have been updated:
Details
Files
Summary by Sourcery
Documentation: