Skip to content

fix: add translate - #720

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:develop/eaglefrom
GongHeng2017:202607311531-dev-eagle-fix
Jul 31, 2026
Merged

fix: add translate#720
deepin-bot[bot] merged 1 commit into
linuxdeepin:develop/eaglefrom
GongHeng2017:202607311531-dev-eagle-fix

Conversation

@GongHeng2017

@GongHeng2017 GongHeng2017 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

-- add translate

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-372319.html

Summary by Sourcery

Bug Fixes:

  • Fix missing and incorrect localized strings for CPU core/count labels in several translation files.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @GongHeng2017, your pull request is larger than the review limit of 150000 diff characters

@sourcery-ai

sourcery-ai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Reviewer's Guide

Updates multiple translation (.ts) files to align with recent source code changes (line numbers) and to add/complete translations for CPU core count labels and several UI texts across locales.

File-Level Changes

Change Details Files
Align translations with updated source locations and add/complete CPU core count and UI string translations across locales.
  • Adjusted line numbers in translation entries to match changes in PageDetail.cpp, DeviceCpu.cpp, DeviceGenerator.cpp, DeviceManager.cpp, DeviceMonitor.cpp, PageDriverInstallInfo.cpp, EDIDParser.cpp, and main.cpp.
  • Filled in previously unfinished CPU core count strings (e.g., One, Two, up to 256) with localized text in zh_TW, bo, ug, zh_CN, zh_HK, and kept English in the base .ts file while adding missing labels.
  • Added many new numeric CPU labels (Three, Five, Seven, etc., through complex ranges like 101–128) and their localized equivalents in multiple language files.
  • Completed or added translations for various UI texts such as "Version Available", driver status summaries (Missing/Outdated/Up-to-date drivers), notification text for new drivers, and "View" button across languages.
  • Ensured consistency of terminology for CPU, device categories, caches, and other hardware terms in all updated translation files.
deepin-devicemanager/translations/deepin-devicemanager_zh_TW.ts
deepin-devicemanager/translations/deepin-devicemanager_bo.ts
deepin-devicemanager/translations/deepin-devicemanager.ts
deepin-devicemanager/translations/deepin-devicemanager_ug.ts
deepin-devicemanager/translations/deepin-devicemanager_zh_CN.ts
deepin-devicemanager/translations/deepin-devicemanager_zh_HK.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, max-lvs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码实现了翻译文件行号的同步更新以及缺失奇数数字翻译的补充,修复了部分翻译格式问题
逻辑正确且无安全风险,资源文件更新规范完整

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

翻译文件(.ts)的 XML 结构完整,新增的奇数数字(如 Three, Five 等)映射条目符合 Qt Linguist 格式规范,原有的行号偏移更新与源代码变更同步
潜在问题:无
建议:保持通过 lupdate 工具自动生成行号映射,避免手动修改带来的偏差

  • 2.代码质量(良好)✓

翻译条目补充完整,修复了 deepin-devicemanager_bo.ts 中 Seventy-eight 翻译存在的多余换行符问题
潜在问题:无
建议:定期检查翻译文件中的空白字符和格式一致性

  • 3.代码性能(无性能问题)✓

翻译文件为静态资源,仅在程序启动或语言切换时加载,对运行时性能无影响
建议:无需优化

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次更新仅涉及翻译资源文件的行号同步和文案补充,无任何外部输入处理或逻辑控制代码,不存在攻击面

  • 建议:无需修复

■ 【改进建议代码示例】

// 无需修改,当前代码已符合规范

@GongHeng2017

Copy link
Copy Markdown
Contributor Author

/forcemerge

@deepin-bot

deepin-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

This pr force merged! (status: unstable)

@deepin-bot
deepin-bot Bot merged commit 1e9928e into linuxdeepin:develop/eagle Jul 31, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants