feat: add AT-SPI accessibleName for all main UI components - #508
Conversation
…ents - Add setAccessibleName() calls to 37 UI controls across 10 source files - Window: EditorWindow, AddTabButton - Tabbar: EditorTabbar - FindBar: FindBar, FindLabel, FindInput, FindPrevButton, FindNextButton, SwitchToReplaceButton, FindBarCloseButton - ReplaceBar: ReplaceBar, ReplaceLabel, ReplaceFindInput, WithLabel, ReplaceWithInput, ReplaceButton, SkipButton, ReplaceRestButton, ReplaceAllButton, ReplaceBarCloseButton - JumpLineBar: JumpLineBar, JumpLineLabel, JumpLineInput, JumpLineCloseButton - ThemePanel, BottomBar and all its child labels/menus/progress bar - TextEditor, EditWrapper, DropdownMenuButton This ensures AT-SPI/ATK can identify all interactive UI elements for accessibility testing frameworks and screen readers. Log: 为deepin-editor补全AT-SPI可访问名称 Issue: V-1366
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: re2zero The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideAdds AT-SPI accessibleName properties across main deepin-editor UI components to improve screen-reader accessibility, and documents the coverage in a new scan report. Flow diagram for AT-SPI accessibleName coverage in main editor UIflowchart TB
EditorWindow["EditorWindow (DMainWindow)"]
EditorWindow --> EditorTabbar["EditorTabbar (DTabBar)"]
EditorTabbar --> AddTabButton["AddTabButton (DIconButton)"]
EditorWindow --> EditWrapper["EditWrapper (QWidget)"]
EditWrapper --> TextEditor["TextEditor (DPlainTextEdit)"]
EditorWindow --> FindBar["FindBar (DFloatingWidget)"]
FindBar --> FindInput["FindInput (LineBar)"]
FindBar --> FindNextButton["FindNextButton (QPushButton)"]
EditorWindow --> ReplaceBar["ReplaceBar (DFloatingWidget)"]
ReplaceBar --> ReplaceFindInput["ReplaceFindInput (LineBar)"]
ReplaceBar --> ReplaceAllButton["ReplaceAllButton (QPushButton)"]
EditorWindow --> JumpLineBar["JumpLineBar (DFloatingWidget)"]
JumpLineBar --> JumpLineInput["JumpLineInput (DSpinBox)"]
EditorWindow --> ThemePanel["ThemePanel (QWidget)"]
EditorWindow --> BottomBar["BottomBar (QWidget)"]
BottomBar --> EncodeMenu["EncodeMenu (DDropdownMenu)"]
EncodeMenu --> DropdownMenuButton["DropdownMenuButton (DToolButton)"]
BottomBar --> HighlightMenu["HighlightMenu (DDropdownMenu)"]
BottomBar --> FormatMenu["FormatMenu (DDropdownMenu)"]
BottomBar --> ProgressBar["ProgressBar (DProgressBar)"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
… scan report - Update copyright year in findbar.cpp: 2011-2023 -> 2011-2026 - Update copyright year in jumplinebar.cpp: 2011-2023 -> 2011-2026 - Update copyright year in themepanel.cpp: 2017-2022 -> 2017-2026 - Add at-spi-scan-report.md to .reuse/dep5 for license compliance Log: 同步版权年份并补充 reuse dep5 声明
|
✅ 本地验证通过 已在本地子项目
备注: |
- Move at-spi-scan-report.md to tests/at/spi/ per convention - Update .reuse/dep5: remove root-level entry, expand tests/at/*.md to also cover tests/at/spi/*.md (existing entry handles subdirectory) Log: 将扫描报告移至 tests/at/spi/ 目录
PR验证结果:通过 ✅验证摘要
Review 详情
清理情况
结论PR 验证通过,可以合并。 |
|
Closing per request - will re-submit with updated workflow constraints |
改动摘要
为 deepin-editor 的所有主要 UI 控件补全了 AT-SPI accessibleName(可访问名称),覆盖 10 个源文件、37 个控件。补全前项目中无任何 setAccessibleName() 调用。
改动的文件
补全详情
详见附件扫描报告。
Issue: V-1366
Summary by Sourcery
Add AT-SPI accessible names to core editor UI components to improve screen reader accessibility.
New Features:
Documentation: