test: add unit tests for common modules - #562
Merged
Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @pengfeixx, your pull request is larger than the review limit of 150,000 diff characters
deepin pr auto reviewAI 代码审查报告提交信息
总体评分
未发现安全漏洞。本 PR 为 deepin-editor 的 common 模块添加了全面的单元测试，覆盖 Settings、Config、Utils、UrlInfo、Eventlogutils、CSyntaxHighlighter、DetectCode、FileLoadThread、IflytekAiAssistant、load_libs、PerformanceMonitor、SaveFileInterface、TextFileSaver 等核心类。测试代码结构规范，注释详尽，隔离措施完善，与 commit 目的完全一致。 漏洞统计
漏洞对比统计：新增漏洞 0 个，减少漏洞 0 个，持平 0 个 四维度评分维度1：语法逻辑（22/25）✓ 语法正确，逻辑清晰评价： 语法正确，逻辑清晰，边界处理完善 分析：
问题：
建议： # 修复方案：改为从环境变量或参数获取构建目录
BD="${BUILD_DIR:-$(dirname "$(dirname "$(readlink -f "$0")")")/build}"维度2：代码质量（23/25）✓ 代码结构清晰，注释完整评价： 代码结构清晰，注释完整，可读性好 分析：
问题：
维度3：代码性能（19/20）✓ 性能良好，资源使用合理评价： 性能良好，资源使用合理，无性能瓶颈 分析：
问题：
维度4：代码安全（30/30）✓ 存在0个安全漏洞评价： 存在0个安全漏洞，安全合规 分析：
审查结论本 PR 为 deepin-editor 项目添加了高质量的单元测试代码，完全符合"为 common 模块添加单元测试"的提交目的。代码覆盖了 13 个核心类的分支路径，测试隔离措施完善（临时目录、DBus stub、offscreen 平台），注释详尽（分支清单与用例映射一一对应）。唯一需要注意的是 修改文件清单
|
pengfeixx
force-pushed
the
test/ut-common
branch
from
September 4, 2026 07:28
0b32fd1 to
df943ce
Compare
Add GTest suites for common utilities: settings, url info, event log, encoding detection, syntax highlighter, file load thread, performance monitor and text file saver. 新增 settings、urlinfo、eventlog、编码检测、语法高亮、文件加载线程、 性能监控、文本保存等公共模块的 GTest 单元测试。 Log: 新增公共模块单元测试 Influence: 仅新增单元测试代码，不影响编辑器本体功能。
pengfeixx
force-pushed
the
test/ut-common
branch
from
September 4, 2026 08:49
df943ce to
b01cd15
Compare
|
Warning
详情 {
"unset": {
"tests/common/test_settings.cpp": {
"b": [
" qunsetenv(\"XDG_CONFIG_HOME\");",
" qunsetenv(\"XDG_SESSION_TYPE\");",
" qunsetenv(\"XDG_CONFIG_HOME\");"
]
},
"tests/common/test_utils.cpp": {
"b": [
" qunsetenv(\"XDG_CONFIG_HOME\");",
" qunsetenv(\"XDG_DATA_HOME\");",
" qunsetenv(\"XDG_SESSION_TYPE\");",
" qunsetenv(\"XDG_SESSION_TYPE\"); // \u4e0e\u672c\u7528\u4f8b qputenv \u914d\u5bf9\u8fd8\u539f"
]
}
}
} |
lzwind
approved these changes
Sep 4, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
新增公共模块的 GTest 单元测试：settings、urlinfo、eventlog、编码检测、语法高亮、文件加载线程、性能监控、文本保存等，共 20 个文件。
说明