Skip to content

fix(pdf): use UUID-only backup filename to avoid NAME_MAX overflow #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
Jul 20, 2026
Merged

fix(pdf): use UUID-only backup filename to avoid NAME_MAX overflow #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions 3rdparty/deepin-pdfium/src/dpdfdoc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2023 UnionTech Software Technology Co., Ltd.
// SPDX-FileCopyrightText: 2023 - 2026 UnionTech Software Technology Co., Ltd.
//
// SPDX-License-Identifier: LGPL-3.0-or-later

Expand Down Expand Up @@ -245,7 +245,7 @@ bool DPdfDoc::save()

QTemporaryDir tempDir;

QString tempFilePath = tempDir.path() + "/" + QUuid::createUuid().toString();
QString tempFilePath = tempDir.path() + "/" + QUuid::createUuid().toString(QUuid::WithoutBraces);

saveWriter.setFileName(tempFilePath);

Expand All @@ -269,9 +269,10 @@ bool DPdfDoc::save()

QString targetPath = d_func()->m_filePath;

// Extract directory and filename to create hidden backup file
// Use a UUID-only hidden file as backup to avoid long filename
// issues with NAME_MAX (255 bytes) on the backup path.
QFileInfo fileInfo(targetPath);
QString backupPath = fileInfo.absolutePath() + "/." + fileInfo.fileName() + ".backup." + QUuid::createUuid().toString();
QString backupPath = fileInfo.absolutePath() + "/." + QUuid::createUuid().toString(QUuid::WithoutBraces);

QFile targetFile(targetPath);

Expand Down
Loading