fix(tests): 修复 test-prj-running.sh 脚本无法构建和生成覆盖率的问题

[pengfeixx]

问题：脚本中 cmake 配置命令被注释、build 目录未创建，导致
make 无 Makefile、测试可执行文件不存在、lcov 找不到 .gcda 文件，
最终生成空的 coverage.info。

修复：

• 自动创建 build 目录并执行 cmake 配置（启用 BUILD_TESTS、 USE_PDFIUM_BUNDLE、CMAKE_BUILD_TYPE=Debug、CMAKE_SAFETYTEST_ARG）
• 使用绝对路径与 script_dir 推导 project_root，避免依赖 PWD
• make 指定 test-deepin-reader 目标，使用 nproc 并行
• 测试执行前 zerocounters，保证覆盖率数据干净
• 报告产物按 build-ut/{html,report,asan.log} 固定输出

Summary by Sourcery

Ensure the test-prj-running.sh script reliably builds the project, runs unit tests, and generates valid coverage and report artifacts.

Enhancements:

• Resolve the project root using the script location so the script is independent of the current working directory.
• Recreate build and report directories on each run to guarantee a clean test and coverage environment.
• Configure CMake with test and debug options enabled before building the test-deepin-reader target in parallel.
• Reset coverage counters and rerun tests to capture accurate coverage data, then filter and generate an HTML report.
• Standardize output locations for HTML coverage, test reports, and ASAN logs under the build-ut directory.

[sourcery-ai]

Reviewer's Guide

The script for running project tests and collecting coverage is refactored to reliably configure, build, execute tests, and produce coverage and report artifacts using robust path handling and clean build/report directories.

File-Level Changes

Change	Details	Files
Make the test runner script robust to working directory and missing build/report directories while enabling test and coverage configuration.	Introduce strict mode with set -u to catch unset variables. Derive script_dir and project_root from the script location instead of relying on PWD. Compute build_path and report_path from project_root and standard directory names. Remove any pre-existing build and report directories and recreate them to ensure a clean run.	tests/test-prj-running.sh
Ensure CMake configuration and test build are executed with appropriate options before running tests.	Run cmake in the build directory with flags to enable tests, PDFium bundle, debug build, and safety test args. Invoke make with -j"$(nproc)" to build only the test-deepin-reader target, improving determinism and performance.	tests/test-prj-running.sh
Improve test execution and coverage collection flow to guarantee non-empty coverage data and consistent output locations.	Create a report directory inside the build tree for gtest XML outputs. Run test-deepin-reader once, then use lcov --zerocounters on the build tree, and rerun tests to get fresh coverage data. Collect coverage with lcov -d ... -c into coverage.info, then filter to keep only reader sources and drop tests. Generate HTML coverage report with genhtml and rename index.html to cov_deepin-reader.html. Copy HTML, gtest report, and ASAN logs into a fixed build-ut report directory under the project root.	tests/test-prj-running.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The tests are executed twice (before and after lcov --zerocounters), which looks redundant; consider dropping the first run unless it is required for a separate purpose not related to coverage.
• The cp -r asan*.log* "${report_path}/asan_deepin-reader.log" invocation is a bit odd (recursive copy into a single file path and a glob that may expand to multiple files); consider simplifying to a non-recursive copy and handling the case of multiple ASAN log files more explicitly.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The tests are executed twice (before and after `lcov --zerocounters`), which looks redundant; consider dropping the first run unless it is required for a separate purpose not related to coverage.
- The `cp -r asan*.log* "${report_path}/asan_deepin-reader.log"` invocation is a bit odd (recursive copy into a single file path and a glob that may expand to multiple files); consider simplifying to a non-recursive copy and handling the case of multiple ASAN log files more explicitly.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[pengfeixx]

/retest

[pengfeixx]

/retest

[pengfeixx]

/retest

[pengfeixx]

/retest

[deepin-ci-robot]

deepin pr auto review

★ 总体评分：92分 - ■ 【总体评价】 > 脚本重构显著提升了路径处理健壮性与构建流程的可靠性，实现了干净的覆盖率收集环境。 > 逻辑严谨且修复了历史配置缺失问题，无安全漏洞，仅在异常处理和资源清理上存在轻微优化空间。 - ■ 【详细分析】 > > - 1.语法逻辑（完全正确）✓ > > 脚本启用了 `set -u` 防止未定义变量误用，路径解析逻辑通过 `cd && pwd` 正确获取绝对路径，构建、测试及覆盖率收集流程顺序合理。 > > 潜在问题：`cmake` 或 `make` 命令失败时，脚本不会立即退出（未启用 `set -e`），可能导致后续步骤在缺少构建产物的情况下继续执行并产生误导性错误。 > > 建议：考虑在关键构建命令后增加错误检查，或直接启用 `set -e` 以确保失败时快速终止。 - > - 2.代码质量（优秀）✓ > > 代码结构清晰，注释详尽且具有指导性，变量命名语义明确（如 `script_dir`、`project_root`），消除了旧脚本中相对路径的脆弱性，清理了历史遗留的注释代码。 > > 潜在问题：无 > > 建议：无 - > - 3.代码性能（高效）✓ > > 使用 `$(nproc)` 动态获取 CPU 核心数进行并行编译，充分利用多核资源，相比旧脚本的 `-j8` 更加智能和高效。清理旧目录保证了无冗余干扰。 > > 潜在问题：连续两次运行 `./tests/test-deepin-reader`（一次为生成初始报告，一次为刷新覆盖率数据），可能导致整体执行时间略微增加。 > > 建议：若测试执行时间较长，可评估是否合并运行步骤，或在第一次运行后直接重置计数器并复用结果。 - > - 4.代码安全（存在0个安全漏洞）✓ > > 漏洞对比统计：新增漏洞 0 个，减少漏洞 0 个，持平 0 个 > > 脚本主要用于本地或 CI 环境的自动化测试，所有变量均通过内部路径解析和固定参数控制，无外部输入注入风险。路径处理使用了双引号包裹，防止了路径包含空格导致的异常。 > > > > - 建议：无需特殊安全修复，保持现有安全编码规范。 - ■ 【改进建议代码示例】

set -eu

builddir=build
reportdir=build-ut

# Resolve project root (parent of the tests/ directory that holds this script)
script_dir="$(cd "$(dirname "$0")" && pwd)"
project_root="$(cd "${script_dir}/.." && pwd)"

build_path="${project_root}/${builddir}"
report_path="${project_root}/${reportdir}"

# Fresh build directory to ensure a clean coverage run
rm -rf "${build_path}"
mkdir -p "${build_path}"

# Fresh report directory
rm -rf "${report_path}"
mkdir -p "${report_path}"

cd "${build_path}"

# Configure project with unit tests and coverage instrumentation enabled
cmake -DCMAKE_SAFETYTEST_ARG="CMAKE_SAFETYTEST_ARG_ON" \
      -DDOTEST=ON \
      -DBUILD_TESTS=ON \
      -DUSE_PDFIUM_BUNDLE=ON \
      -DCMAKE_BUILD_TYPE=Debug \
      "${project_root}"

# Compile tests target
make -j"$(nproc)" test-deepin-reader

# Ensure report directory used by gtest exists inside the build tree
mkdir -p "${build_path}/report"

# Run tests and produce XML report
./tests/test-deepin-reader --gtest_output=xml:"${build_path}/report/report_deepin-reader.xml"

# Directory that holds coverage artifacts (build tree of the project)
workdir="${build_path}"

# Reset any stale coverage counters before recapture
lcov --directory "${workdir}" --zerocounters || true

# Re-run tests so .gcda files reflect a clean run
./tests/test-deepin-reader --gtest_output=xml:"${build_path}/report/report_deepin-reader.xml"

# Collect coverage data
lcov -d "${workdir}" -c -o ./coverage.info

# Keep only reader sources, drop tests themselves
lcov --extract ./coverage.info '*/reader/*' -o ./coverage.info
lcov --remove  ./coverage.info '*/tests/*' -o ./coverage.info

# Generate HTML report
genhtml -o ./html ./coverage.info

# Rename main index for downstream tooling
mv ./html/index.html ./html/cov_deepin-reader.html

# Publish artifacts into project report dir
cp -r html  "${report_path}/"
cp -r "${build_path}/report" "${report_path}/"
cp -r asan*.log* "${report_path}/asan_deepin-reader.log" 2>/dev/null || true

exit 0

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, pengfeixx

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pengfeixx]

/merge