test(at): stabilize deepin reader yaml suites - #313
Conversation
Use AT-SPI element actions for sidebar controls and trim flaky steps. 使用 AT-SPI 元素动作替代不稳定点击,并收敛易波动步骤。 Log: 稳定 deepin-reader AT YAML 用例 Influence: 提升 AT YAML 用例在本地和远端环境的执行稳定性,整套用例通过。
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR stabilizes Deepin Reader AT YAML suites by updating element roles to better match actual accessibility semantics and trimming or adjusting flaky interaction steps across multiple suite files, particularly for sidebar, menu, search, and tab bar interactions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review★ 总体评分:95分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 # 建议使用动态等待替代硬编码 wait,以提升稳定性(伪代码示例)
setup:
- action: session_start
command: deepin-reader ${TEST_FILES_DIR}/normal.pdf
wait_until: element_visible # 动态等待条件
selector:
name: Form_CentralDocPage
role: form
timeout: 10.0 # 最大超时时间 |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Several sidebar elements (thumbnail/catalog/bookmark/annotation) no longer constrain on role; if their AT-SPI roles are stable, consider retaining role filters to avoid over-broad matches when names collide or change.
- Changing
pageEditfrompaneltotextalters how interactions resolve; if this element needs both container and editable semantics, consider defining separate elements for the container and the editable field instead of overloading one.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Several sidebar elements (thumbnail/catalog/bookmark/annotation) no longer constrain on role; if their AT-SPI roles are stable, consider retaining role filters to avoid over-broad matches when names collide or change.
- Changing `pageEdit` from `panel` to `text` alters how interactions resolve; if this element needs both container and editable semantics, consider defining separate elements for the container and the editable field instead of overloading one.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
Stabilize Deepin Reader accessibility test suites by updating element definitions and pruning flaky interactions.
Tests: