fix(reader): construct QSet with explicit insert loop for Qt5/Qt6 com… - #366
Merged
deepin-bot[bot] merged 1 commit intoSep 4, 2026
Merged
Conversation
…patibility The iterator-range constructor QSet(begin, end) was introduced in Qt 5.14, causing a build failure on Qt 5.11.3. Using QSet::fromList() instead would break Qt6 builds since it was removed in Qt6. Replace with an explicit insert loop, which compiles on all supported Qt versions (5.11.3, 5.14+, and 6.x). Log: 修复QSet构造方式在Qt5.11.3和Qt6上的编译兼容性问题 Bug: 本地编译时发现的问题,并无 bug 链接 Influence: 解决reader模块在Qt5.11.3下编译报错,同时保持Qt6兼容
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates restored-file set construction in the reader to avoid the QSet iterator-range constructor unavailable in Qt 5.11.3, while retaining compatibility with Qt 6 and existing file merge behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
lzwind
approved these changes
Sep 4, 2026
add-uos
approved these changes
Sep 4, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, GongHeng2017, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: unstable) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…patibility
The iterator-range constructor QSet(begin, end) was introduced in Qt 5.14, causing a build failure on Qt 5.11.3. Using QSet::fromList() instead would break Qt6 builds since it was removed in Qt6. Replace with an explicit insert loop, which compiles on all supported Qt versions (5.11.3, 5.14+, and 6.x).
Log: 修复QSet构造方式在Qt5.11.3和Qt6上的编译兼容性问题
Bug: 本地编译时发现的问题,并无 bug 链接
Influence: 解决reader模块在Qt5.11.3下编译报错,同时保持Qt6兼容
Summary by Sourcery
Bug Fixes: