fix(reader): close FindWidget on tab switch to prevent cross-document… - #372
Merged
deepin-bot[bot] merged 1 commit intoSep 8, 2026
Conversation
… search When switching between document tabs, the FindWidget (whose parent is the MainWindow, not the SheetBrowser) remained visible with its m_docSheet pointer still bound to the previous document. Searching from this stale widget executed the search on the wrong document. Add SheetBrowser::hideFindWidget() to hide and destroy the FindWidget, DocSheet::closeFindWidget() to stop the search and hide the widget, and call prevSheet->closeFindWidget() in CentralDocPage::onTabChanged() before switching to the new tab. Log: fix issue Bug: https://pms.uniontech.com/bug-view-376317.html
Reviewer's GuideFix cross-document search after tab switches by stopping the previous sheet’s search and hiding/deleting its FindWidget before activating the new document, with explicit cleanup APIs and updated copyright metadata. Sequence diagram for closing search on document tab switchsequenceDiagram
participant CentralDocPage
participant PreviousDocSheet
participant PreviousSheetBrowser
participant NewDocSheet
CentralDocPage->>PreviousDocSheet: closeFindWidget()
PreviousDocSheet->>PreviousDocSheet: stopSearch()
PreviousDocSheet->>PreviousSheetBrowser: hideFindWidget()
PreviousSheetBrowser->>PreviousSheetBrowser: hide()
PreviousSheetBrowser->>PreviousSheetBrowser: deleteLater()
CentralDocPage->>CentralDocPage: setCurrentWidget(NewDocSheet)
CentralDocPage->>NewDocSheet: defaultFocus()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
max-lvs
approved these changes
Sep 8, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GongHeng2017, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… search
When switching between document tabs, the FindWidget (whose parent is the MainWindow, not the SheetBrowser) remained visible with its m_docSheet pointer still bound to the previous document. Searching from this stale widget executed the search on the wrong document.
Add SheetBrowser::hideFindWidget() to hide and destroy the FindWidget, DocSheet::closeFindWidget() to stop the search and hide the widget, and call prevSheet->closeFindWidget() in CentralDocPage::onTabChanged() before switching to the new tab.
Log: fix issue
Bug: https://pms.uniontech.com/bug-view-376317.html
Summary by Sourcery
Prevent cross-document searches by closing the previous document's search widget before activating a new tab.
Bug Fixes:
Enhancements: